Related to T2636
Details
Details
- Reviewers
ardumont vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T2636: Modify generation of full-context SWHID for root artifacts by omitting path classifier
- Commits
- rDWAPPS3e8584e9f805: SWHIDs: Do not add path qualifier for a root directory
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- swhid-no-path-for-root-dir
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15567 Build 23970: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 23969: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D4050 (id=14275)
Rebasing onto 7ac279dfd0...
Current branch diff-target is up to date.
Changes applied before test
commit 2c60bd05fe126e0d02d6a5220eb5d5209c00d9a4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Sep 25 14:41:48 2020 +0200
SWHIDs: Do not add path qualifier for a root directory
Related to T2636See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/391/ for more details.
Comment Actions
one remark but otherwise, looks good.
thanks
| swh/web/tests/browse/views/test_content.py | ||
|---|---|---|
| 527 | maybe keep at least one somewhere to demonstrate that it's flipped to None if that occurs? | |
| swh/web/tests/browse/views/test_content.py | ||
|---|---|---|
| 527 | Yes, good idea ! I will add the check in test_get_swhids_info_directory_context. | |
Comment Actions
Build is green
Patch application report for D4050 (id=14276)
Rebasing onto 7ac279dfd0...
Current branch diff-target is up to date.
Changes applied before test
commit 3e8584e9f80568e386141b452988e87cd5062d55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Fri Sep 25 14:41:48 2020 +0200
SWHIDs: Do not add path qualifier for a root directory
Related to T2636See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/392/ for more details.