- Remove the old (and unused) .clang-format to use Spotless
- Add a pre-commit hook to enforce style
- Fix style on the Java codebase
Details
- Reviewers
zack seirl - Group Reviewers
Reviewers - Commits
- rDGRPHfcffd0d2c2b5: java: style: add Spotless formatting tool
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Branch
- feature/spotless
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15485 Build 23852: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 23851: arc lint + arc unit
Time | Test | |
---|---|---|
3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_count self = <RemoteGraphClient url=http://127.0.0.1:36647/graph/>
response = <Response [400]>
| |
4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_leaves self = <RemoteGraphClient url=http://127.0.0.1:36647/graph/>
response = <Response [400]>
| |
3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_neighbors self = <RemoteGraphClient url=http://127.0.0.1:36647/graph/>
response = <Response [400]>
| |
3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_random_walk self = <RemoteGraphClient url=http://127.0.0.1:36647/graph/>
response = <Response [400]>
| |
3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_api_client::test_visit_edges self = <RemoteGraphClient url=http://127.0.0.1:36647/graph/>
response = <Response [400]>
| |
View Full Test Results (8 Failed · 24 Passed · 2 Skipped) |
Event Timeline
Build has FAILED
Patch application report for D4028 (id=14208)
Rebasing onto c293d0726a...
First, rewinding head to replay your work on top of it... Applying: style: run Spotless formatting tool
Changes applied before test
commit 573cc0afdc6d283b7034e52da6cea6d4cfc17703 Author: Thibault Allançon <haltode@gmail.com> Date: Thu Sep 24 09:45:59 2020 +0200 style: run Spotless formatting tool Remove the old (and unused) .clang-format to use Spotless. Add a pre-commit hook to enforce style.
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/51/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/51/console
There's some issue with the reformating in comments, it adds a space between <a href= and the next quote
java/src/main/java/org/softwareheritage/graph/AllowedEdges.java | ||
---|---|---|
8–12 | Fix space between href and quote. | |
java/src/main/java/org/softwareheritage/graph/maps/LabelMapBuilder.java | ||
110–114 | Fix inline comments | |
java/src/main/java/org/softwareheritage/graph/maps/NodeIdMap.java | ||
59–62 | Fix inline comments | |
97–101 | Fix inline comments. | |
java/src/main/java/org/softwareheritage/graph/maps/NodeMapBuilder.java | ||
27–32 | Fix list formatting | |
122–123 | Fix inline comments. |
Build has FAILED
Patch application report for D4028 (id=14209)
Rebasing onto c293d0726a...
First, rewinding head to replay your work on top of it... Applying: style: run Spotless formatting tool
Changes applied before test
commit 1466b9d146ac17d5e25930a3ffececd90892179d Author: Thibault Allançon <haltode@gmail.com> Date: Thu Sep 24 09:45:59 2020 +0200 style: run Spotless formatting tool Remove the old (and unused) .clang-format to use Spotless. Add a pre-commit hook to enforce style.
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/52/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/52/console
Build has FAILED
Patch application report for D4028 (id=14210)
Rebasing onto c293d0726a...
First, rewinding head to replay your work on top of it... Applying: style: run Spotless formatting tool
Changes applied before test
commit 5371154d377a23d83e20b29687ae2d813420838c Author: Thibault Allançon <haltode@gmail.com> Date: Thu Sep 24 09:45:59 2020 +0200 style: run Spotless formatting tool Remove the old (and unused) .clang-format to use Spotless. Add a pre-commit hook to enforce style.
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/53/console
Build has FAILED
Patch application report for D4028 (id=14212)
Rebasing onto c293d0726a...
Current branch diff-target is up to date.
Changes applied before test
commit 230002e55353f9a1ae2c6f25ddff8f7abd747708 Author: Thibault Allançon <haltode@gmail.com> Date: Thu Sep 24 09:45:59 2020 +0200 java: style: add Spotless formatting tool - Replace the old (and unused) .clang-format with Spotless - Add a pre-commit hook to enforce style - Fix style on the Java codebase
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/54/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/54/console
Rebase on master.
Conflicts:
- java/src/main/java/org/softwareheritage/graph/AllowedEdges.java
- java/src/test/java/org/softwareheritage/graph/AllowedEdgesTest.java
- java/src/test/java/org/softwareheritage/graph/GraphTest.java
- java/src/test/java/org/softwareheritage/graph/WalkTest.java
Build has FAILED
Patch application report for D4028 (id=14629)
Rebasing onto 29ae6bf46d...
Current branch diff-target is up to date.
Changes applied before test
commit fcffd0d2c2b5821c84266ea8b29676c258933e88 Author: Thibault Allançon <haltode@gmail.com> Date: Tue Oct 6 09:11:13 2020 +0200 java: style: add Spotless formatting tool - Replace the old (and unused) .clang-format with Spotless - Add a pre-commit hook to enforce style - Fix style on the Java codebase
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/58/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/58/console