Page MenuHomeSoftware Heritage
Differential D4028

Add Spotless formatting tool
ClosedPublic
Actions

Authored by haltode on Sep 24 2020, 10:09 AM.

Details

Reviewers
zack
seirl
Group Reviewers
Reviewers
Commits
rDGRPHfcffd0d2c2b5: java: style: add Spotless formatting tool
Summary
  • Remove the old (and unused) .clang-format to use Spotless
  • Add a pre-commit hook to enforce style
  • Fix style on the Java codebase

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Sep 24 2020, 10:09 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2020, 10:09 AM
swh-public-ci added a comment.Sep 24 2020, 10:11 AM

Build has FAILED

Patch application report for D4028 (id=14208)

Rebasing onto c293d0726a...

First, rewinding head to replay your work on top of it...
Applying: style: run Spotless formatting tool
Changes applied before test
commit 573cc0afdc6d283b7034e52da6cea6d4cfc17703
Author: Thibault Allançon <haltode@gmail.com>
Date:   Thu Sep 24 09:45:59 2020 +0200

    style: run Spotless formatting tool
    
    Remove the old (and unused) .clang-format to use Spotless. Add a
    pre-commit hook to enforce style.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/51/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/51/console

Harbormaster failed remote builds in B15483: Diff 14208!Sep 24 2020, 10:11 AM
vlorentz added a subscriber: vlorentz.Sep 24 2020, 10:22 AM

There's some issue with the reformating in comments, it adds a space between <a href= and the next quote

haltode added inline comments.Sep 24 2020, 10:24 AM
java/src/main/java/org/softwareheritage/graph/AllowedEdges.java
8–12

Fix space between href and quote.

java/src/main/java/org/softwareheritage/graph/maps/LabelMapBuilder.java
110–114

Fix inline comments

java/src/main/java/org/softwareheritage/graph/maps/NodeIdMap.java
59–62

Fix inline comments

97–101

Fix inline comments.

java/src/main/java/org/softwareheritage/graph/maps/NodeMapBuilder.java
27–32

Fix list formatting

122–123

Fix inline comments.

haltode updated this revision to Diff 14209.Sep 24 2020, 10:42 AM

Fix comments formatting.

haltode marked an inline comment as not done.Sep 24 2020, 10:43 AM
swh-public-ci added a comment.Sep 24 2020, 10:44 AM

Build has FAILED

Patch application report for D4028 (id=14209)

Rebasing onto c293d0726a...

First, rewinding head to replay your work on top of it...
Applying: style: run Spotless formatting tool
Changes applied before test
commit 1466b9d146ac17d5e25930a3ffececd90892179d
Author: Thibault Allançon <haltode@gmail.com>
Date:   Thu Sep 24 09:45:59 2020 +0200

    style: run Spotless formatting tool
    
    Remove the old (and unused) .clang-format to use Spotless. Add a
    pre-commit hook to enforce style.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/52/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/52/console

Harbormaster failed remote builds in B15484: Diff 14209!Sep 24 2020, 10:44 AM
haltode updated this revision to Diff 14210.Sep 24 2020, 10:57 AM

Fix HTML whitespace before quote.

swh-public-ci added a comment.Sep 24 2020, 10:58 AM

Build has FAILED

Patch application report for D4028 (id=14210)

Rebasing onto c293d0726a...

First, rewinding head to replay your work on top of it...
Applying: style: run Spotless formatting tool
Changes applied before test
commit 5371154d377a23d83e20b29687ae2d813420838c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Thu Sep 24 09:45:59 2020 +0200

    style: run Spotless formatting tool
    
    Remove the old (and unused) .clang-format to use Spotless. Add a
    pre-commit hook to enforce style.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/53/console

Harbormaster failed remote builds in B15485: Diff 14210!Sep 24 2020, 10:58 AM
haltode updated this revision to Diff 14212.Sep 24 2020, 11:23 AM

Rebasing on master.

swh-public-ci added a comment.Sep 24 2020, 11:24 AM

Build has FAILED

Patch application report for D4028 (id=14212)

Rebasing onto c293d0726a...

Current branch diff-target is up to date.
Changes applied before test
commit 230002e55353f9a1ae2c6f25ddff8f7abd747708
Author: Thibault Allançon <haltode@gmail.com>
Date:   Thu Sep 24 09:45:59 2020 +0200

    java: style: add Spotless formatting tool
    
    - Replace the old (and unused) .clang-format with Spotless
    - Add a pre-commit hook to enforce style
    - Fix style on the Java codebase

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/54/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/54/console

Harbormaster failed remote builds in B15487: Diff 14212!Sep 24 2020, 11:24 AM
haltode updated this revision to Diff 14629.Oct 6 2020, 9:13 AM

Rebase on master.

Conflicts:

  • java/src/main/java/org/softwareheritage/graph/AllowedEdges.java
  • java/src/test/java/org/softwareheritage/graph/AllowedEdgesTest.java
  • java/src/test/java/org/softwareheritage/graph/GraphTest.java
  • java/src/test/java/org/softwareheritage/graph/WalkTest.java
swh-public-ci added a comment.Oct 6 2020, 9:15 AM

Build has FAILED

Patch application report for D4028 (id=14629)

Rebasing onto 29ae6bf46d...

Current branch diff-target is up to date.
Changes applied before test
commit fcffd0d2c2b5821c84266ea8b29676c258933e88
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 6 09:11:13 2020 +0200

    java: style: add Spotless formatting tool
    
    - Replace the old (and unused) .clang-format with Spotless
    - Add a pre-commit hook to enforce style
    - Fix style on the Java codebase

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/58/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/58/console

Harbormaster failed remote builds in B15910: Diff 14629!Oct 6 2020, 9:15 AM
zack accepted this revision.Oct 6 2020, 9:18 AM
This revision is now accepted and ready to land.Oct 6 2020, 9:18 AM
seirl accepted this revision.Oct 7 2020, 1:11 PM
This revision was landed with ongoing or failed builds.Oct 7 2020, 1:13 PM
Closed by commit rDGRPHfcffd0d2c2b5: java: style: add Spotless formatting tool (authored by haltode). · Explain Why
This revision was automatically updated to reflect the committed changes.
haltode added a commit: rDGRPHfcffd0d2c2b5: java: style: add Spotless formatting tool.

Revision Contents
Changeset List

PathSize
9 lines
java/
16 lines
31 lines
src/
main/
java/
org/
softwareheritage/
graph/
13 lines
15 lines
33 lines
5 lines
24 lines
4 lines
75 lines
benchmark/
18 lines
26 lines
10 lines
24 lines
6 lines
experiments/
forks/
16 lines
25 lines
42 lines
27 lines
17 lines
multiplicationfactor/
34 lines
topology/
29 lines
30 lines
299 lines
134 lines
maps/
78 lines
6 lines
16 lines
73 lines
14 lines
server/
6 lines
9 lines
utils/
20 lines
7 lines
18 lines
test/
java/
org/
softwareheritage/
graph/
7 lines
274 lines
172 lines

Diff 14692

View Options

.pre-commit-config.yaml

Loading...
View Options

java/.clang-format

Loading...
View Options

java/.coding-style.xml

Loading...
View Options

java/pom.xml

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/AllowedEdges.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/Entry.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/Graph.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/Node.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/SWHID.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/Stats.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/Traversal.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/benchmark/BFS.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/benchmark/Benchmark.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/benchmark/Browsing.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/benchmark/Provenance.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/benchmark/Vault.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/forks/FindCommonAncestor.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/forks/FindPath.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/forks/ForkCC.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/forks/ForkCliques.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/forks/ListEmptyOrigins.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/multiplicationfactor/GenDistribution.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/topology/ClusteringCoefficient.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/topology/ConnectedComponents.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/topology/InOutDegree.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/experiments/topology/SubdatasetSizeFunction.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/maps/LabelMapBuilder.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/maps/MapFile.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/maps/NodeIdMap.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/maps/NodeMapBuilder.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/maps/NodeTypesMap.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/server/App.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/server/Endpoint.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/utils/MPHTranslate.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/utils/ReadGraph.java

Loading...
View Options

java/src/main/java/org/softwareheritage/graph/utils/ReadLabelledGraph.java

Loading...
View Options

java/src/test/java/org/softwareheritage/graph/AllowedEdgesTest.java

Loading...
View Options

java/src/test/java/org/softwareheritage/graph/VisitTest.java

Loading...
View Options

java/src/test/java/org/softwareheritage/graph/WalkTest.java

Loading...
About · Developer information · Legal