Paths

Table of Contentst

pg: Write origin visit updates & status, read from origin_visit_status
ClosedPublic
Actions

Authored by ardumont on May 27 2020, 2:20 PM.

Details

Reviewers

vlorentz
olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2310: Make origin visits immutable

Commits

rDSTOcada7fc5de8e: pg: Write origin visit updates & status, read from origin_visit_status

Summary

That still writes new origin visit and origin visit status but reads from
origin visit status.

This partially reverts commit b0b767b91ca077a14368eaac1f98120261d7460c [1]

This almost realigns the pg storage with other storage implementations (those
no longer wrote origin-visit-update since D3101).

[1] Related to D3101
Related to T2310

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12505
Build 18989: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18988: arc lint + arc unit

Event Timeline

ardumont created this revision.May 27 2020, 2:20 PM

Build is green

Patch application report for D3180 (id=11312)

Rebasing onto 213f1b1239...

Current branch diff-target is up to date.

Changes applied before test

commit dca1891283e3545080a9f6a1e672e01008ce9032
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 14:11:22 2020 +0200

    pg: Write origin visit updates & status, read from origin_visit_status
    
    That still writes new origin visit and origin visit status but reads from
    origin visit status.
    
    This partially reverts commit b0b767b91ca077a14368eaac1f98120261d7460c [1]
    
    [1] Related to D3101

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/193/ for more details.

Harbormaster completed remote builds in B12505: Diff 11312.May 27 2020, 2:27 PM

ardumont mentioned this in T2310: Make origin visits immutable.May 27 2020, 4:18 PM

vlorentz accepted this revision.May 28 2020, 9:31 AM

This revision is now accepted and ready to land.May 28 2020, 9:31 AM

Could my comment be implemented in a followup diff?

swh/storage/db.py
699–702	Ugh. Can we get rid of `mogrify` here by building a list of query variables instead?

Could my comment be implemented in a followup diff?

Sure, as soon as I wrap my head around it :D

ardumont edited the summary of this revision. (Show Details)May 28 2020, 11:35 AM

ardumont added a project: Storage manager.

Rebase on latest master

Build is green

Patch application report for D3180 (id=11339)

Rebasing onto fe877ce3a0...

Current branch diff-target is up to date.

Changes applied before test

commit cada7fc5de8e12f757e4a729ab59ebdcaaf9d867
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 14:11:22 2020 +0200

    pg: Write origin visit updates & status, read from origin_visit_status
    
    That still writes new origin visit and origin visit status but reads from
    origin visit status.
    
    This partially reverts commit b0b767b91ca077a14368eaac1f98120261d7460c [1]
    
    [1] Related to D3101

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/201/ for more details.

Harbormaster completed remote builds in B12532: Diff 11339.May 28 2020, 1:14 PM

Closed by commit rDSTOcada7fc5de8e: pg: Write origin visit updates & status, read from origin_visit_status (authored by ardumont). · Explain WhyMay 28 2020, 1:19 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOcada7fc5de8e: pg: Write origin visit updates & status, read from origin_visit_status.

ardumont mentioned this in D3193: db: Use query_params instead of mogrify.May 28 2020, 1:33 PM

ardumont added inline comments.May 28 2020, 1:34 PM