Page MenuHomeSoftware Heritage

pg: Write origin visit updates & status, read from origin_visit_status
ClosedPublic

Authored by ardumont on May 27 2020, 2:20 PM.

Details

Summary

That still writes new origin visit and origin visit status but reads from
origin visit status.

This partially reverts commit b0b767b91ca077a14368eaac1f98120261d7460c [1]

This almost realigns the pg storage with other storage implementations (those
no longer wrote origin-visit-update since D3101).

[1] Related to D3101
Related to T2310

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 27 2020, 2:20 PM

Build is green

Patch application report for D3180 (id=11312)

Rebasing onto 213f1b1239...

Current branch diff-target is up to date.
Changes applied before test
commit dca1891283e3545080a9f6a1e672e01008ce9032
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 14:11:22 2020 +0200

    pg: Write origin visit updates & status, read from origin_visit_status
    
    That still writes new origin visit and origin visit status but reads from
    origin visit status.
    
    This partially reverts commit b0b767b91ca077a14368eaac1f98120261d7460c [1]
    
    [1] Related to D3101

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/193/ for more details.

vlorentz accepted this revision.May 28 2020, 9:31 AM
This revision is now accepted and ready to land.May 28 2020, 9:31 AM
olasd accepted this revision.May 28 2020, 11:31 AM
olasd added a subscriber: olasd.

Could my comment be implemented in a followup diff?

swh/storage/db.py
699–702

Ugh. Can we get rid of mogrify here by building a list of query variables instead?

Could my comment be implemented in a followup diff?

Sure, as soon as I wrap my head around it :D

ardumont edited the summary of this revision. (Show Details)May 28 2020, 11:35 AM
ardumont added a project: Storage manager.
ardumont updated this revision to Diff 11339.May 28 2020, 1:07 PM
ardumont edited the summary of this revision. (Show Details)

Rebase on latest master

Build is green

Patch application report for D3180 (id=11339)

Rebasing onto fe877ce3a0...

Current branch diff-target is up to date.
Changes applied before test
commit cada7fc5de8e12f757e4a729ab59ebdcaaf9d867
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 27 14:11:22 2020 +0200

    pg: Write origin visit updates & status, read from origin_visit_status
    
    That still writes new origin visit and origin visit status but reads from
    origin visit status.
    
    This partially reverts commit b0b767b91ca077a14368eaac1f98120261d7460c [1]
    
    [1] Related to D3101

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/201/ for more details.

ardumont added inline comments.May 28 2020, 1:34 PM
swh/storage/db.py
699–702