A test is added to ensure the pagination and the data typing are
working as expected.
Details
Details
- Reviewers
zack ardumont - Group Reviewers
Reviewers - Commits
- rDWCLI6bb36697bea8: client: add `visits` method to get the list of an origin visits
Diff Detail
Diff Detail
- Repository
- rDWCLI Web client
- Branch
- visits
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12150 Build 18432: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 18431: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWCLI/job/tox/18/ for more details.
Comment Actions
Build is green
Patch application report for D2881 (id=10488)
Rebasing onto 492be567e2...
Current branch diff-target is up to date.
Changes applied before test
commit 151b77349d34ead96b6667e472761b57e0454f3c
Author: Antoine Eiche <lewo@abesis.fr>
Date: Wed Mar 25 17:52:19 2020 +0100
client: add `visits` method to get the list of an origin visits
A test is added to ensure the pagination and the data typing are
working as expected.See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/3/ for more details.
Comment Actions
LGTM, just minor docstring/comment issue, then we're good to go
thanks !
Do not forget to add yourself to the top-level CONTRIBUTORS file
| swh/web/client/client.py | ||
|---|---|---|
| 346 | maybe "origin: the URL of a software origin" | |
| 347 | just "number of visits to list", for consistency with other docstrings | |
| swh/web/client/tests/conftest.py | ||
| 22–23 | this is no longer "the only URL" :-) can you fix this comment and the one you copied this from, to simply state why each URL needs monkey patching? | |
| swh/web/client/client.py | ||
|---|---|---|
| 355 | indentation ;) | |
Comment Actions
Build is green
Patch application report for D2881 (id=10500)
Rebasing onto 492be567e2...
Current branch diff-target is up to date.
Changes applied before test
commit 8d47566785824aa219ddb44e51e7b364b2fca54c
Author: Antoine Eiche <lewo@abesis.fr>
Date: Wed Mar 25 17:52:19 2020 +0100
client: add `visits` method to get the list of an origin visits
A test is added to ensure the pagination and the data typing are
working as expected.See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/4/ for more details.
Comment Actions
Build is green
Patch application report for D2881 (id=10731)
Rebasing onto e5ef2a0dc3...
Current branch diff-target is up to date.
Changes applied before test
commit 7622c584ea6c9aeaaba38264b19145258ce7b78f
Author: Antoine Eiche <lewo@abesis.fr>
Date: Wed Mar 25 17:52:19 2020 +0100
client: add `visits` method to get the list of an origin visits
A test is added to ensure the pagination and the data typing are
working as expected.See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/7/ for more details.
Comment Actions
Build is green
Patch application report for D2881 (id=10996)
Rebasing onto 3a493dbf55...
Current branch diff-target is up to date.
Changes applied before test
commit 6bb36697bea8288c9d84a77c4e0dc0fc82bf27c6
Author: Antoine Eiche <lewo@abesis.fr>
Date: Wed Mar 25 17:52:19 2020 +0100
client: add `visits` method to get the list of an origin visits
A test is added to ensure the pagination and the data typing are
working as expected.See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/8/ for more details.