Page MenuHomeSoftware Heritage
Differential D2881

client: add `visits` method to get the list of an origin visits
ClosedPublic
Actions

Authored by lewo on Mar 25 2020, 6:07 PM.

Details

Reviewers
zack
ardumont
Group Reviewers
Reviewers
Commits
rDWCLI6bb36697bea8: client: add `visits` method to get the list of an origin visits
Summary

A test is added to ensure the pagination and the data typing are
working as expected.

Diff Detail

Repository
rDWCLI Web client
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11337
Build 17155: tox-on-jenkinsJenkins
Build 17154: arc lint + arc unit

Event Timeline

lewo created this revision.Mar 25 2020, 6:07 PM
swh-public-ci added a comment.Mar 25 2020, 6:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWCLI/job/tox/18/ for more details.

Harbormaster completed remote builds in B11337: Diff 10259.Mar 25 2020, 6:07 PM
zack added a reviewer: Reviewers.Apr 2 2020, 11:34 AM
olasd added a subscriber: olasd.Apr 2 2020, 11:40 AM
olasd added inline comments.
swh/web/client/client.py
49

We use origin_visit in most places, so I guess this should use that name as well.

364

Should have a trailing slash.

swh/web/client/tests/gen-api-data.sh
33

If you add the trailing slash you shouldn't need to follow redirects.

lewo updated this revision to Diff 10488.Apr 2 2020, 3:13 PM
lewo marked 3 inline comments as done.

@olasd I addressed all of your comments. Thanks for your review.

swh-public-ci added a comment.Apr 2 2020, 3:17 PM

Build is green

Patch application report for D2881 (id=10488)

Rebasing onto 492be567e2...

Current branch diff-target is up to date.
Changes applied before test
commit 151b77349d34ead96b6667e472761b57e0454f3c
Author: Antoine Eiche <lewo@abesis.fr>
Date:   Wed Mar 25 17:52:19 2020 +0100

    client: add `visits` method to get the list of an origin visits
    
    A test is added to ensure the pagination and the data typing are
    working as expected.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/3/ for more details.

Harbormaster completed remote builds in B11580: Diff 10488.Apr 2 2020, 3:17 PM
zack requested changes to this revision.Apr 2 2020, 5:10 PM

LGTM, just minor docstring/comment issue, then we're good to go

thanks !

Do not forget to add yourself to the top-level CONTRIBUTORS file

swh/web/client/client.py
342

maybe "origin: the URL of a software origin"

343

just "number of visits to list", for consistency with other docstrings

swh/web/client/tests/conftest.py
23–24

this is no longer "the only URL" :-)

can you fix this comment and the one you copied this from, to simply state why each URL needs monkey patching?

This revision now requires changes to proceed.Apr 2 2020, 5:10 PM
ardumont added a subscriber: ardumont.Apr 2 2020, 5:22 PM
ardumont added inline comments.
swh/web/client/client.py
351

indentation ;)

lewo updated this revision to Diff 10500.Apr 2 2020, 6:23 PM

Thanks @zack @ardumont. I addressed your comments.

swh-public-ci added a comment.Apr 2 2020, 6:28 PM

Build is green

Patch application report for D2881 (id=10500)

Rebasing onto 492be567e2...

Current branch diff-target is up to date.
Changes applied before test
commit 8d47566785824aa219ddb44e51e7b364b2fca54c
Author: Antoine Eiche <lewo@abesis.fr>
Date:   Wed Mar 25 17:52:19 2020 +0100

    client: add `visits` method to get the list of an origin visits
    
    A test is added to ensure the pagination and the data typing are
    working as expected.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/4/ for more details.

Harbormaster completed remote builds in B11592: Diff 10500.Apr 2 2020, 6:28 PM
ardumont accepted this revision.Apr 2 2020, 6:55 PM

fine for me and thanks ;)

zack accepted this revision.Apr 14 2020, 11:40 AM
This revision is now accepted and ready to land.Apr 14 2020, 11:40 AM
lewo updated this revision to Diff 10731.Apr 15 2020, 10:40 AM

Rebased

swh-public-ci added a comment.Apr 15 2020, 10:44 AM

Build is green

Patch application report for D2881 (id=10731)

Rebasing onto e5ef2a0dc3...

Current branch diff-target is up to date.
Changes applied before test
commit 7622c584ea6c9aeaaba38264b19145258ce7b78f
Author: Antoine Eiche <lewo@abesis.fr>
Date:   Wed Mar 25 17:52:19 2020 +0100

    client: add `visits` method to get the list of an origin visits
    
    A test is added to ensure the pagination and the data typing are
    working as expected.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/7/ for more details.

Harbormaster completed remote builds in B11851: Diff 10731.Apr 15 2020, 10:44 AM
ardumont added a comment.Apr 23 2020, 11:34 PM

@lewo ping ;)

lewo updated this revision to Diff 10996.Apr 29 2020, 4:37 PM

Rebased

swh-public-ci added a comment.Apr 29 2020, 4:42 PM

Build is green

Patch application report for D2881 (id=10996)

Rebasing onto 3a493dbf55...

Current branch diff-target is up to date.
Changes applied before test
commit 6bb36697bea8288c9d84a77c4e0dc0fc82bf27c6
Author: Antoine Eiche <lewo@abesis.fr>
Date:   Wed Mar 25 17:52:19 2020 +0100

    client: add `visits` method to get the list of an origin visits
    
    A test is added to ensure the pagination and the data typing are
    working as expected.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/8/ for more details.

Harbormaster completed remote builds in B12150: Diff 10996.Apr 29 2020, 4:42 PM
Closed by commit rDWCLI6bb36697bea8: client: add `visits` method to get the list of an origin visits (authored by lewo). · Explain WhyApr 29 2020, 4:43 PM
This revision was automatically updated to reflect the committed changes.
lewo added a commit: rDWCLI6bb36697bea8: client: add `visits` method to get the list of an origin visits.

Revision Contents
Changeset List

PathSize
swh/
web/
client/
46 lines
tests/
210 lines
7 lines
4 lines
15 lines

Diff 10259

View Options

swh/web/client/client.py

Loading...
View Options

swh/web/client/tests/api_data.py

Loading...
View Options

swh/web/client/tests/conftest.py

Loading...
View Options

swh/web/client/tests/gen-api-data.sh

Loading...
View Options

swh/web/client/tests/test_web_api_client.py

Loading...
About · Developer information · Legal