Page MenuHomeSoftware Heritage
Create Task
Maniphest T78

Unable to perfectly round-trip releases pointed at by occurrences
Closed, MigratedEdits Locked
Actions

Description

The current model for occurrences and releases makes it impossible to list the releases that appear for a given origin at a given time.

When we store an occurrence that points to a release, we "peel" the release until we find a revision, and store that.

This means that when we want to list the releases that were found on a given origin, we need to "backtrack" all the releases that point to some revisions that have been found in the origin. We therefore get a superset of the releases found at the origin (nothing prevents another origin from having other annotated releases pointing to the revisions we have in our origin).

One possible solution would be to let occurrences point to releases instead of being peeled down to revisions.

Related Objects
Search...

Event Timeline

olasd created this task.Oct 7 2015, 1:57 PM
olasd raised the priority of this task from to Normal.
olasd updated the task description. (Show Details)
olasd added projects: Developers, Staff, Storage manager.
olasd added a subscriber: olasd.
zack mentioned this in T67: prototype: git clone from SWH.Oct 7 2015, 3:15 PM
rdicosmo added a subscriber: rdicosmo.Jan 15 2016, 9:08 AM

What about having "occurrences" for all kinds of objects in a VCS, releases, tags, revisions, etc. ?
We would definitely need to look at other VCS to get a general model; for example, in Darcs patches are first class citizens: do we have a way of accomodating this in our data model?

Let's remember that it's OK to focus on git as a priority, but it's NOT OK to believe its data model covers everything.

zack added a subscriber: zack.Jan 15 2016, 9:28 AM

What about having "occurrences" for all kinds of objects in a VCS, releases, tags, revisions, etc. ?

That is in fact already the case. All "top-level" objects visible in a repository have entries in the occurrence table. For Git, this means "refs", that are used for both tags and branches.
Individual commits do not have entries in the occurrence table, but that is just an optimization which does not lose information. Starting from refs we can reach any other (retrievable) commit in the Git repository, and storing an occurrence entry for the ref we can know exactly which commits were there.

Let's remember that it's OK to focus on git as a priority, but it's NOT OK to believe its data model covers everything.

Absolutely. Our focus on Git right now has been based on the hypothesis that it is the most general model we've stumbled upon up to now, with reasonable confidence that it will also fit other models. But of course this hypothesis hasn't been tested much yet, so it is still under review :-) Regarding darcs, it is indeed possible that we will have to store more entries in the occurrence table to cope with it. Or maybe find some different solution altogether.

ardumont added a subscriber: ardumont.Jan 15 2016, 3:26 PM
olasd mentioned this in rDSTOe8154c74f831: sql: make occurrences and revisions use type agnostic targets.Jan 25 2016, 4:04 PM
olasd closed this task as Resolved.Jan 26 2016, 7:46 AM
olasd claimed this task.

This has now been deployed in swh.storage v0.0.30: occurrences and releases can now point to arbitrary objects.

rdicosmo added a comment.Jan 26 2016, 9:10 AM

Cool!

Roberto Di Cosmo (via mobile/cell)
Le 26 janv. 2016 07:47, "olasd (Nicolas Dandrimont)" <
forge@softwareheritage.org> a écrit :

olasd closed this task as "Resolved".
olasd claimed this task.
olasd added a comment.

This has now been deployed in swh.storage v0.0.30: occurrences and

releases can now point to arbitrary objects.

TASK DETAIL

https://forge.softwareheritage.org/T78

EMAIL PREFERENCES

https://forge.softwareheritage.org/settings/panel/emailpreferences/

To: olasd
Cc: ardumont, zack, rdicosmo, olasd

ardumont mentioned this in rDWAPPS039b81744bc0: Release can point to other objects than revision.Jan 26 2016, 12:26 PM
zack removed projects: Staff, Developers.Mar 10 2016, 5:52 PM
olasd changed the visibility from "All Users" to "Public (No Login Required)".May 13 2016, 5:06 PM
qcampos mentioned this in rDOBJSce73d5f157ba: sql: make occurrences and revisions use type agnostic targets.Jun 27 2016, 1:46 PM
ardumont mentioned this in R65:039b81744bc0: Release can point to other objects than revision.Feb 23 2019, 1:55 AM
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:16 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal