Page MenuHomeSoftware Heritage
Create Task
Maniphest T2331

Improve handling of GitLab origins in Save Code Now requests
Closed, MigratedEdits Locked
Actions

Description

The logic for filtering bad requests for Save Code Now needs to be improved to handle the fact that GitLab allows subprojects.
For example, https://gitlab.inria.fr/solverstack/maphys/maphys/ is a legitimate origin, but it is flagged as invalid by the WebApp for the moment.

Revisions and Commits

rDWAPPS Web applications
D2878rDWAPPSdc89829a02eb assets/utils: Validate sub-projects in isGitRepoUrl function

Related Objects

Event Timeline

rdicosmo triaged this task as Normal priority.Mar 24 2020, 11:42 AM
rdicosmo created this task.
anlambert mentioned this in D2878: assets/utils: Validate sub-projects in isGitRepoUrl function.Mar 25 2020, 5:11 PM
anlambert closed this task as Resolved by committing rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function.Mar 25 2020, 6:05 PM
anlambert added a commit: rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function.
rdicosmo reopened this task as Open.Mar 25 2020, 6:35 PM

It looks like the patch only fixes the issue for the gitlab.com origin, while the issue is present in all origins that are instances of GitLab, like https://gitlab.inria.fr/solverstack/maphys/maphys/

olasd added a subscriber: olasd.Mar 25 2020, 6:40 PM

The patch only adds a test for an origin url under gitlab.com, but the regular expression change actually allows multiple levels of directories for any origin.

anlambert closed this task as Resolved.Mar 25 2020, 6:41 PM

The patch hopefully fixes all type of git repository urls. I think you got mistaken by the frontend test, the real fix is in the regexp modification.
Nervertheless, this is not deployed yet.

rdicosmo added a comment.Mar 25 2020, 7:01 PM

Ok, great!

gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:30 PM
gitlab-migration claimed this task.
gitlab-migration added subscribers: anlambert, gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal