Page MenuHomeSoftware Heritage

Factorize list merges in indexer mappings
ClosedPublic

Authored by vlorentz on Jan 15 2019, 8:22 PM.

Diff Detail

Repository
rDCIDX Object indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 15 2019, 8:22 PM
douardda requested changes to this revision.Jan 16 2019, 10:27 AM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/indexer/metadata_dictionary.py
164

Why a method? self is unused, so a bare function is fine here.

Which then allows you to very easily write unit tests for ๐Ÿ˜„

This revision now requires changes to proceed.Jan 16 2019, 10:27 AM
vlorentz marked an inline comment as done.Jan 16 2019, 11:27 AM
vlorentz updated this revision to Diff 3050.Jan 16 2019, 11:27 AM
  • Move merge_values out of a class and add test.
vlorentz updated this revision to Diff 3051.Jan 16 2019, 11:27 AM
  • fix base commit
Harbormaster failed remote builds in B3557: Diff 3051!
ardumont accepted this revision.Jan 21 2019, 10:23 AM
vlorentz updated this revision to Diff 3160.Jan 24 2019, 3:10 PM
  • Rebase
douardda accepted this revision.Jan 24 2019, 5:30 PM
This revision is now accepted and ready to land.Jan 24 2019, 5:30 PM
This revision was automatically updated to reflect the committed changes.