Page MenuHomeSoftware Heritage
Differential D957

Factorize list merges in indexer mappings
ClosedPublic
Actions

Authored by vlorentz on Jan 15 2019, 8:22 PM.

Details

Reviewers
douardda
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1328: Add Ruby/Gem metadata indexer
Commits
rDCIDX71d63ce79ca0: Factorize list merges.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 15 2019, 8:22 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2019, 8:22 PM
vlorentz added a parent revision: D956: Add gemspec mapping..Jan 15 2019, 8:22 PM
Harbormaster failed remote builds in B3550: Diff 3047!Jan 15 2019, 8:22 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 15 2019, 8:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/222/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/222/console

douardda requested changes to this revision.Jan 16 2019, 10:27 AM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/indexer/metadata_dictionary.py
163

Why a method? self is unused, so a bare function is fine here.

Which then allows you to very easily write unit tests for 😄

This revision now requires changes to proceed.Jan 16 2019, 10:27 AM
vlorentz marked an inline comment as done.Jan 16 2019, 11:27 AM
vlorentz updated this revision to Diff 3050.Jan 16 2019, 11:27 AM
  • Move merge_values out of a class and add test.
vlorentz updated this revision to Diff 3051.Jan 16 2019, 11:27 AM
  • fix base commit
swh-public-ci added a comment.Jan 16 2019, 11:29 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/223/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/223/console

Harbormaster failed remote builds in B3556: Diff 3050!Jan 16 2019, 11:29 AM
Harbormaster failed remote builds in B3557: Diff 3051!
swh-public-ci added a comment.Jan 16 2019, 11:29 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/224/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/224/console

vlorentz added a child revision: D965: Add more type checks to sanitize Mappings' input..Jan 16 2019, 6:28 PM
vlorentz updated this revision to Diff 3073.Jan 17 2019, 11:52 AM
  • rebase
Harbormaster failed remote builds in B3582: Diff 3073!Jan 17 2019, 11:52 AM
swh-public-ci added a comment.Jan 17 2019, 11:53 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/231/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/231/console

ardumont accepted this revision.Jan 21 2019, 10:23 AM
vlorentz added a task: T1328: Add Ruby/Gem metadata indexer.Jan 21 2019, 3:54 PM
vlorentz updated this revision to Diff 3160.Jan 24 2019, 3:10 PM
  • Rebase
Harbormaster failed remote builds in B3686: Diff 3160!Jan 24 2019, 3:10 PM
swh-public-ci added a comment.Jan 24 2019, 3:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/265/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/265/console

douardda accepted this revision.Jan 24 2019, 5:30 PM
This revision is now accepted and ready to land.Jan 24 2019, 5:30 PM
vlorentz updated this revision to Diff 3228.Jan 29 2019, 10:15 AM
  • rebase
Closed by commit rDCIDX71d63ce79ca0: Factorize list merges. (authored by vlorentz). · Explain WhyJan 29 2019, 10:15 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3772: Diff 3228!Jan 29 2019, 10:15 AM
swh-public-ci added a comment.Jan 29 2019, 10:15 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/283/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/283/console

Revision Contents
Changeset List

PathSize
swh/
indexer/
63 lines
tests/
28 lines

Diff 3229

View Options

swh/indexer/metadata_dictionary.py

Loading...
View Options

swh/indexer/tests/test_metadata.py

Loading...
About · Developer information · Legal