Differential D8799

codemeta: Fix crash on SWORD documents that specify an id
ClosedPublic
Actions

Authored by vlorentz on Nov 2 2022, 9:35 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T4667: JsonLdError: ('Invalid JSON-LD syntax; "@id" value must be a string.',)

Commits

rDCIDX41e90e4ae6f2: codemeta: Fix crash on SWORD documents that specify an id

Summary

Resolves T4667.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32663
Build 51171: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51170: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 2 2022, 9:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 2 2022, 9:35 AM

Build is green

Patch application report for D8799 (id=31710)

Rebasing onto 3bad41489c...

Current branch diff-target is up to date.

Changes applied before test

commit e113b61a94aaedb59a0f614ba816268126e65839
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 2 09:35:05 2022 +0100

    codemeta: Fix crash on SWORD documents that specify an id

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/522/ for more details.

Harbormaster completed remote builds in B32659: Diff 31710.Nov 2 2022, 9:39 AM

vlorentz requested review of this revision.Nov 2 2022, 9:39 AM

olasd added a subscriber: olasd.Nov 2 2022, 12:55 PM

olasd added inline comments.

swh/indexer/metadata_dictionary/codemeta.py
113	Shouldn't this spit a warning of some sort?

add logging

Build is green

Patch application report for D8799 (id=31714)

Rebasing onto 3bad41489c...

Current branch diff-target is up to date.

Changes applied before test

commit 41e90e4ae6f212fe76be71bd8904a7e8a10daca4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 2 09:35:05 2022 +0100

    codemeta: Fix crash on SWORD documents that specify an id

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/523/ for more details.

Harbormaster completed remote builds in B32663: Diff 31714.Nov 2 2022, 1:11 PM

Thanks!

This revision is now accepted and ready to land.Nov 2 2022, 1:22 PM

ardumont added a subscriber: ardumont.Nov 2 2022, 2:25 PM

ardumont added inline comments.