Page MenuHomeSoftware Heritage

utils: Report svnadmin load error in init_svn_repo_from_dump
ClosedPublic

Authored by anlambert on Oct 18 2022, 7:57 PM.

Details

Summary

When the svnadmin load command exits with error, report the svn
admin error in the ValueError exception raised by the function
init_svn_repo_from_dump.

This should help debugging those type of issues reported by sentry.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
report-svnadmin-load-error
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32436
Build 50803: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50802: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8739 (id=31491)

Rebasing onto 8e38d524c0...

First, rewinding head to replay your work on top of it...
Applying: utils: Report svnadmin load error in init_svn_repo_from_dump
Changes applied before test
commit 62aeb391904803bc61ee787c003f563461bad788
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 19:55:09 2022 +0200

    utils: Report svnadmin load error in init_svn_repo_from_dump
    
    When the "svnadmin load" command exits with error, report the svn
    admin error in the ValueError exception raised by the function
    init_svn_repo_from_dump.
    
    This should help debugging those type of issues reported by sentry.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/340/ for more details.

This revision is now accepted and ready to land.Oct 19 2022, 9:35 AM

Build is green

Patch application report for D8739 (id=31513)

Rebasing onto 8e38d524c0...

Current branch diff-target is up to date.
Changes applied before test
commit fcf2addb17e971e2f30eb2d4efed80fd044255ec
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 19:55:09 2022 +0200

    utils: Report svnadmin load error in init_svn_repo_from_dump
    
    When the "svnadmin load" command exits with error, report the svn
    admin error in the ValueError exception raised by the function
    init_svn_repo_from_dump.
    
    This should help debugging those type of issues reported by sentry.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/341/ for more details.