utils: Report svnadmin load error in init_svn_repo_from_dump
ClosedPublic
Actions

Authored by anlambert on Oct 18 2022, 7:57 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVNfcf2addb17e9: utils: Report svnadmin load error in init_svn_repo_from_dump

Summary

When the svnadmin load command exits with error, report the svn
admin error in the ValueError exception raised by the function
init_svn_repo_from_dump.

This should help debugging those type of issues reported by sentry.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 18 2022, 7:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2022, 7:57 PM

Build is green

Patch application report for D8739 (id=31491)

Rebasing onto 8e38d524c0...

First, rewinding head to replay your work on top of it...
Applying: utils: Report svnadmin load error in init_svn_repo_from_dump

Changes applied before test

commit 62aeb391904803bc61ee787c003f563461bad788
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 19:55:09 2022 +0200

    utils: Report svnadmin load error in init_svn_repo_from_dump
    
    When the "svnadmin load" command exits with error, report the svn
    admin error in the ValueError exception raised by the function
    init_svn_repo_from_dump.
    
    This should help debugging those type of issues reported by sentry.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/340/ for more details.

Harbormaster completed remote builds in B32436: Diff 31491.Oct 18 2022, 8:11 PM

anlambert requested review of this revision.Oct 18 2022, 8:11 PM

anlambert edited the summary of this revision. (Show Details)Oct 18 2022, 8:14 PM

ardumont accepted this revision.Oct 19 2022, 9:35 AM

This revision is now accepted and ready to land.Oct 19 2022, 9:35 AM

Rebase

Build is green

Patch application report for D8739 (id=31513)

Rebasing onto 8e38d524c0...

Current branch diff-target is up to date.

Changes applied before test

commit fcf2addb17e971e2f30eb2d4efed80fd044255ec
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 19:55:09 2022 +0200

    utils: Report svnadmin load error in init_svn_repo_from_dump
    
    When the "svnadmin load" command exits with error, report the svn
    admin error in the ValueError exception raised by the function
    init_svn_repo_from_dump.
    
    This should help debugging those type of issues reported by sentry.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/341/ for more details.

Harbormaster completed remote builds in B32457: Diff 31513.Oct 19 2022, 11:04 AM

Closed by commit rDLDSVNfcf2addb17e9: utils: Report svnadmin load error in init_svn_repo_from_dump (authored by anlambert). · Explain WhyOct 19 2022, 12:07 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNfcf2addb17e9: utils: Report svnadmin load error in init_svn_repo_from_dump.