Paths

Table of Contentst

Differential D8514

Fix validateForgeUrl
ClosedPublic
Actions

Authored by vlorentz on Sep 20 2022, 10:06 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS376df84e0379: Fix validateForgeUrl

Summary

It rejected all URLs, because the protocol always ends with a colon.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31636
Build 49483: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49482: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 20 2022, 10:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 20 2022, 10:06 PM

Build is green

Patch application report for D8514 (id=30657)

Rebasing onto d6031c131b...

Current branch diff-target is up to date.

Changes applied before test

commit 376df84e037915c0596a54671c8dd62fcdb6eaa6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 20 22:06:11 2022 +0200

    Fix validateForgeUrl
    
    It rejected all URLs, because the protocol always ends with a colon.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2070/ for more details.

Harbormaster completed remote builds in B31636: Diff 30657.Sep 20 2022, 10:15 PM

vlorentz requested review of this revision.Sep 20 2022, 10:15 PM

Argh, why cypress tests did not catch this ? thanks !

This revision is now accepted and ready to land.Sep 21 2022, 10:52 AM

Closed by commit rDWAPPS376df84e0379: Fix validateForgeUrl (authored by vlorentz). · Explain WhySep 21 2022, 10:53 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS376df84e0379: Fix validateForgeUrl.

In D8514#220858, @anlambert wrote:

Argh, why cypress tests did not catch this ? thanks !

So we use cy.submit() to submit the form in cypress tests but it seems to bypass HTML checks, using cy.click() on the submit button
seems the right way to proceed. I will update our cypress tests with that pattern then.

anlambert mentioned this in D8516: cypress: Use click command instead of submit one for form submission.Sep 21 2022, 1:42 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

web/

add_forge_now/

assets/

create-request.js

2 lines

97%

Diff 30657

View Options

swh/web/add_forge_now/assets/create-request.js

Fix validateForgeUrlClosedPublicActions