Page MenuHomeSoftware Heritage
Differential D8447

Add max_matching_nodes parameter to /leaves
ClosedPublic
Actions

Authored by vlorentz on Sep 12 2022, 3:07 PM.

Details

Reviewers
olasd
douardda
Group Reviewers
Reviewers
Maniphest Tasks
T3626: graph API: add ?limit parameter to /leaves endpoint
Commits
rDGRPH68591a22012a: Add max_matching_nodes parameter to /leaves
Summary

To match the new parameter in the gRPC API

Resolves T3626.

Depends on D8438.

Diff Detail

Event Timeline

vlorentz created this revision.Sep 12 2022, 3:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 12 2022, 3:07 PM
vlorentz edited the summary of this revision. (Show Details)Sep 12 2022, 3:17 PM
vlorentz added a parent revision: D8438: Add field 'max_matching_nodes' to TraversalRequest.
swh-public-ci added a comment.Sep 12 2022, 3:23 PM

Build was aborted

Patch application report for D8447 (id=30456)

Could not rebase; Attempt merge onto 071271daa4...

Updating 071271d..bd36c7a
Fast-forward
 java/pom.xml                                       |  6 ++
 .../org/softwareheritage/graph/rpc/Traversal.java  | 34 ++++++++---
 .../java/org/softwareheritage/graph/GraphTest.java | 29 +++++++++
 .../softwareheritage/graph/rpc/CountEdgesTest.java | 25 ++++++++
 .../softwareheritage/graph/rpc/CountNodesTest.java | 23 ++++++++
 .../graph/rpc/TraverseLeavesTest.java              | 43 ++++++++++++--
 proto/swhgraph.proto                               |  3 +
 swh/graph/http_client.py                           | 17 +++++-
 swh/graph/http_naive_client.py                     | 25 ++++++--
 swh/graph/http_server.py                           | 12 ++--
 swh/graph/rpc/swhgraph_pb2.py                      | 68 +++++++++++-----------
 swh/graph/rpc/swhgraph_pb2.pyi                     | 13 ++++-
 swh/graph/tests/test_http_client.py                | 30 ++++++++++
 13 files changed, 269 insertions(+), 59 deletions(-)
Changes applied before test
commit bd36c7a821208555ea9fb906134a09afeb4795be
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 12 15:06:54 2022 +0200

    Add max_matching_nodes parameter to /leaves
    
    To match the new parameter in the gRPC API

commit 44f2b1fd38c55139ca59809d51f70e9c488b24b8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/231/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/231/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 3:23 PM
Harbormaster failed remote builds in B31466: Diff 30456!
vlorentz updated this revision to Diff 30462.Sep 12 2022, 3:26 PM

rebase

swh-public-ci added a comment.Sep 12 2022, 3:40 PM

Build has FAILED

Patch application report for D8447 (id=30462)

Could not rebase; Attempt merge onto 7049b584c2...

Updating 7049b58..372a7dd
Fast-forward
 java/pom.xml                                       |  6 ++
 .../org/softwareheritage/graph/rpc/Traversal.java  | 34 ++++++++---
 .../java/org/softwareheritage/graph/GraphTest.java | 29 +++++++++
 .../softwareheritage/graph/rpc/CountEdgesTest.java | 25 ++++++++
 .../softwareheritage/graph/rpc/CountNodesTest.java | 23 ++++++++
 .../graph/rpc/TraverseLeavesTest.java              | 43 ++++++++++++--
 proto/swhgraph.proto                               |  3 +
 swh/graph/http_client.py                           | 17 +++++-
 swh/graph/http_naive_client.py                     | 25 ++++++--
 swh/graph/http_server.py                           | 12 ++--
 swh/graph/rpc/swhgraph_pb2.py                      | 68 +++++++++++-----------
 swh/graph/rpc/swhgraph_pb2.pyi                     | 13 ++++-
 swh/graph/tests/test_http_client.py                | 30 ++++++++++
 13 files changed, 269 insertions(+), 59 deletions(-)
Changes applied before test
commit 372a7ddc889ca754187849f9dc1ab66f643149bc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 12 15:06:54 2022 +0200

    Add max_matching_nodes parameter to /leaves
    
    To match the new parameter in the gRPC API

commit b54abaddd950b89c66f97177659868397d0bcc68
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/234/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/234/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 3:41 PM
Harbormaster failed remote builds in B31472: Diff 30462!
swh-public-ci added a comment.Sep 15 2022, 8:43 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/240/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/240/console

vlorentz updated this revision to Diff 30814.Sep 27 2022, 1:05 PM

rebase

swh-public-ci added a comment.Sep 27 2022, 1:09 PM

Build has FAILED

Patch application report for D8447 (id=30814)

Could not rebase; Attempt merge onto a426c1d038...

Updating a426c1d..1979eee
Fast-forward
 java/pom.xml                                       |   6 +
 .../org/softwareheritage/graph/rpc/Traversal.java  |  34 +-
 .../java/org/softwareheritage/graph/GraphTest.java |  29 ++
 .../softwareheritage/graph/rpc/CountEdgesTest.java |  25 ++
 .../softwareheritage/graph/rpc/CountNodesTest.java |  23 +
 .../graph/rpc/TraverseLeavesTest.java              |  43 +-
 proto/swhgraph.proto                               |   3 +
 swh/graph/grpc/swhgraph_pb2.py                     |  68 +--
 swh/graph/grpc/swhgraph_pb2.pyi                    | 481 +++++++++++----------
 swh/graph/http_client.py                           |  17 +-
 swh/graph/http_naive_client.py                     |  25 +-
 swh/graph/http_rpc_server.py                       |  12 +-
 swh/graph/tests/test_http_client.py                |  30 ++
 13 files changed, 504 insertions(+), 292 deletions(-)
Changes applied before test
commit 1979eee09cd29d62b2aab4bb48021caca378f6de
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 12 15:06:54 2022 +0200

    Add max_matching_nodes parameter to /leaves
    
    To match the new parameter in the gRPC API

commit c9585be99ef981c3c3b0784a88ecd7d4f4a9d614
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/243/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/243/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 27 2022, 1:10 PM
Harbormaster failed remote builds in B31790: Diff 30814!
vlorentz updated this revision to Diff 30817.Sep 27 2022, 1:52 PM

rebase

swh-public-ci added a comment.Sep 27 2022, 1:58 PM

Build is green

Patch application report for D8447 (id=30817)

Could not rebase; Attempt merge onto a426c1d038...

Updating a426c1d..68591a2
Fast-forward
 java/pom.xml                                       |   6 +
 .../org/softwareheritage/graph/rpc/Traversal.java  |  34 +-
 .../java/org/softwareheritage/graph/GraphTest.java |  29 ++
 .../softwareheritage/graph/rpc/CountEdgesTest.java |  25 ++
 .../softwareheritage/graph/rpc/CountNodesTest.java |  23 +
 .../graph/rpc/TraverseLeavesTest.java              |  43 +-
 proto/swhgraph.proto                               |   3 +
 requirements.txt                                   |   1 +
 swh/graph/grpc/swhgraph_pb2.py                     |  68 +--
 swh/graph/grpc/swhgraph_pb2.pyi                    | 481 +++++++++++----------
 swh/graph/http_client.py                           |  17 +-
 swh/graph/http_naive_client.py                     |  25 +-
 swh/graph/http_rpc_server.py                       |  12 +-
 swh/graph/tests/test_http_client.py                |  30 ++
 14 files changed, 505 insertions(+), 292 deletions(-)
Changes applied before test
commit 68591a22012afaded36e2387d24298ab6ca0f79f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 12 15:06:54 2022 +0200

    Add max_matching_nodes parameter to /leaves
    
    To match the new parameter in the gRPC API

commit 337269942b12c1f8203e1a7e46538436dcd85f5b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

commit 76b9820a75aba519c3667765bfa1bc145c55a342
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 27 13:50:34 2022 +0200

    Exclude protobuf 4.21.*
    
    It crashes when swhgraph_pb2.py is discovered by pytest.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/246/ for more details.

Harbormaster completed remote builds in B31793: Diff 30817.Sep 27 2022, 1:58 PM
vlorentz requested review of this revision.Sep 27 2022, 1:58 PM
olasd accepted this revision.Sep 27 2022, 3:10 PM
This revision is now accepted and ready to land.Sep 27 2022, 3:10 PM
douardda accepted this revision.Sep 27 2022, 3:11 PM
douardda added a subscriber: douardda.

lgtm

Closed by commit rDGRPH68591a22012a: Add max_matching_nodes parameter to /leaves (authored by vlorentz). · Explain WhySep 27 2022, 3:13 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDGRPH68591a22012a: Add max_matching_nodes parameter to /leaves.

Revision Contents
Changeset List

PathSize
swh/
graph/
17 lines
25 lines
12 lines
tests/
30 lines

Diff 30462

View Options

swh/graph/http_client.py

Loading...
View Options

swh/graph/http_naive_client.py

Loading...
View Options

swh/graph/http_server.py

Loading...
View Options

swh/graph/tests/test_http_client.py

Loading...
About · Developer information · Legal