Page MenuHomeSoftware Heritage

Align swh.indexer.storage.api.server.launch with swh.storage.api.server.launch
ClosedPublic

Authored by vlorentz on Dec 14 2018, 3:49 PM.

Details

Summary

As far as I can tell (grepping through the doc and Pupper config),
this entrypoint is not used anywhere.

Diff Detail

Repository
rDCIDX Object indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 14 2018, 3:49 PM
vlorentz edited the summary of this revision. (Show Details)Dec 14 2018, 3:49 PM

If default_config_path becomes obsolete, you can also remove it.

As far as I can tell (grepping through the doc and Pupper config),
this entrypoint is not used anywhere.

And yes, this endpoint is most probably used by developer (i do).

If default_config_path becomes obsolete, you can also remove it.

It's used so nvm.

ardumont accepted this revision.Dec 14 2018, 3:56 PM

Can you please also bump the dependency for swh-core 0.0.48, that will help for the db initialization step in T1444?

This revision is now accepted and ready to land.Dec 14 2018, 3:56 PM

Can you please also bump the dependency for swh-core 0.0.48, that will help for the db initialization step in T1444?

Why? Just to get rid of the docker cache?

Can you please also bump the dependency for swh-core 0.0.48, that will help for the db initialization step in T1444?

Why? Just to get rid of the docker cache?

To actually be able to use the db initialization idempotency without to have to override the docker-compose with volumes.
as done in D815 and not yet in D818 (theswh.core tag is deployed now).

Can you please also bump the dependency for swh-core 0.0.48, that will help for the db initialization step in T1444?

Why? Just to get rid of the docker cache?

To actually be able to use the db initialization idempotency without to have to override the docker-compose with volumes.
as done in D815 and not yet in D818 (theswh.core tag is deployed now).

So... yes?

It's not swh.indexer that depends on swh-core 0.0.48, it's its docker file.

Can you please also bump the dependency for swh-core 0.0.48, that will help for the db initialization step in T1444?

Why? Just to get rid of the docker cache?

To actually be able to use the db initialization idempotency without to have to override the docker-compose with volumes.
as done in D815 and not yet in D818 (theswh.core tag is deployed now).

So... yes?

It's not swh.indexer that depends on swh-core 0.0.48, it's its docker file.

I meant D817, not D815!

Yes but we will install swh-indexer as pip install swh-indexer, so will need that to draw the new version of the core...

Yes but we will install swh-indexer as pip install swh-indexer, so will need that to draw the new version of the core...

That pip command is cached too.

You need to clear your docker cache either way.

Yes but we will install swh-indexer as pip install swh-indexer, so will need that to draw the new version of the core...

That pip command is cached too.

You need to clear your docker cache either way.

Will that install specifically the latest swh-core?
That might be the source of our misunderstanding.

Will that install specifically the latest swh-core?
That might be the source of our misunderstanding.

Two possibilities:

  1. you don't clear your docker cache, and docker does not run pip at all, so neither swh-indexer nor swh-core is updated
  2. you clear your docker cache, and docker runs "pip install swh.indexer". As pip was never run before in the dockerfile, pip won't have any cache, so it will install the latest version of swh.indexer, and the latest version of each of its dependencies, including swh.core.

Will that install specifically the latest swh-core?
That might be the source of our misunderstanding.

Two possibilities:

  1. you don't clear your docker cache, and docker does not run pip at all, so neither swh-indexer nor swh-core is updated
  2. you clear your docker cache, and docker runs "pip install swh.indexer". As pip was never run before in the dockerfile, pip won't have any cache, so it will install the latest version of swh.indexer, and the latest version of each of its dependencies, including swh.core.

Yes, i was speaking in the case of 2. clearing the cache first then pip install does the rest and use the latest version of what it found.
So all should be good to go.

This revision was automatically updated to reflect the committed changes.