Page MenuHomeSoftware Heritage
Differential D824

Add indexer storage service.
ClosedPublic
Actions

Authored by vlorentz on Dec 14 2018, 4:10 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDENVa4fe146d5893: Add indexer storage service.
rCDFDa4fe146d5893: Add indexer storage service.
Summary

Depends on D822.

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 14 2018, 4:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2018, 4:10 PM
Harbormaster completed remote builds in B3046: Diff 2620.Dec 14 2018, 4:10 PM
ardumont added a subscriber: ardumont.Dec 14 2018, 4:11 PM
ardumont added inline comments.
dockerfiles/swh-indexer-storage/entrypoint.sh
38

sounds like formatting issues with mix tab/spaces ;)

vlorentz updated this revision to Diff 2621.Dec 14 2018, 4:16 PM
  • remove tabs.
Harbormaster completed remote builds in B3048: Diff 2621.Dec 14 2018, 4:16 PM
vlorentz marked an inline comment as done.Dec 14 2018, 4:16 PM
ardumont requested changes to this revision.Dec 14 2018, 4:20 PM

Sounds good, misses the swh.yml adaptation and it's good to go.

docker-compose.yml
44

why not a dash, isn't it supported?

65

Can you please change the web.yml of the webapp services so that it uses the indexer as well.

This revision now requires changes to proceed.Dec 14 2018, 4:20 PM
vlorentz updated this revision to Diff 2622.Dec 14 2018, 4:22 PM
  • Make swh-web use the idx storage.
Harbormaster completed remote builds in B3050: Diff 2622.Dec 14 2018, 4:22 PM
vlorentz updated this revision to Diff 2623.Dec 14 2018, 4:23 PM
  • fix typo
  • Make swh-web use the idx storage.
Harbormaster completed remote builds in B3051: Diff 2623.Dec 14 2018, 4:23 PM
vlorentz marked an inline comment as done.Dec 14 2018, 4:23 PM
vlorentz marked an inline comment as done.
ardumont accepted this revision.Dec 14 2018, 4:30 PM

I'm still unsure about the waiting for psql to start but the rest is quite fine!

This revision is now accepted and ready to land.Dec 14 2018, 4:30 PM
ardumont mentioned this in T1443: Make swh services run within docker and docker-compose.Dec 14 2018, 4:52 PM
vlorentz updated this revision to Diff 2637.Dec 17 2018, 11:05 AM
  • squash
Harbormaster completed remote builds in B3068: Diff 2637.Dec 17 2018, 11:05 AM
Closed by commit rCDFDa4fe146d5893: Add indexer storage service. (authored by vlorentz). · Explain WhyDec 17 2018, 11:05 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDENVa4fe146d5893: Add indexer storage service..Nov 26 2019, 1:34 PM

Revision Contents
Changeset List

PathSize
31 lines
dockerfiles/
swh-indexer-storage/
14 lines
40 lines
4 lines
swh-web/
5 lines

Diff 2638

View Options

docker-compose.yml

Loading...
View Options

dockerfiles/swh-indexer-storage/Dockerfile

Loading...
View Options

dockerfiles/swh-indexer-storage/entrypoint.sh

Loading...
View Options

dockerfiles/swh-indexer-storage/indexer_storage.yml

Loading...
View Options

dockerfiles/swh-web/web.yml

Loading...
About · Developer information · Legal