Page MenuHomeSoftware Heritage

Add indexer storage service.
ClosedPublic

Authored by vlorentz on Dec 14 2018, 4:10 PM.

Details

Summary

Depends on D822.

Diff Detail

Repository
rCDFD Dockerfiles for developers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 14 2018, 4:10 PM
ardumont added inline comments.
dockerfiles/swh-indexer-storage/entrypoint.sh
39

sounds like formatting issues with mix tab/spaces ;)

vlorentz updated this revision to Diff 2621.Dec 14 2018, 4:16 PM
  • remove tabs.
vlorentz marked an inline comment as done.Dec 14 2018, 4:16 PM
ardumont requested changes to this revision.Dec 14 2018, 4:20 PM

Sounds good, misses the swh.yml adaptation and it's good to go.

docker-compose.yml
45

why not a dash, isn't it supported?

66

Can you please change the web.yml of the webapp services so that it uses the indexer as well.

This revision now requires changes to proceed.Dec 14 2018, 4:20 PM
vlorentz updated this revision to Diff 2622.Dec 14 2018, 4:22 PM
  • Make swh-web use the idx storage.
vlorentz updated this revision to Diff 2623.Dec 14 2018, 4:23 PM
  • fix typo
  • Make swh-web use the idx storage.
vlorentz marked an inline comment as done.Dec 14 2018, 4:23 PM
vlorentz marked an inline comment as done.
ardumont accepted this revision.Dec 14 2018, 4:30 PM

I'm still unsure about the waiting for psql to start but the rest is quite fine!

This revision is now accepted and ready to land.Dec 14 2018, 4:30 PM
This revision was automatically updated to reflect the committed changes.