Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T4402: Pass dict of hashes instead of single sha1 to objstorage.get()
- Commits
- rDCIDX42cb37769714: rehash: Call objstorage.content_get() with a HashDict instead of single hash
Depends on D8122
Diff Detail
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Branch
- objid
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 30452 Build 47606: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 47605: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D8135 (id=29378)
Rebasing onto fa67b73d6a...
First, rewinding head to replay your work on top of it... Applying: rehash: Call objstorage.content_get() with a HashDict instead of single hash
Changes applied before test
commit b319f2a4f54bd9ac676abf805b39cc47aff1787b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 14:09:46 2022 +0200
rehash: Call objstorage.content_get() with a HashDict instead of single hash
Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/361/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/361/console
Comment Actions
Build is green
Patch application report for D8135 (id=29378)
Rebasing onto 466108c166...
First, rewinding head to replay your work on top of it... Applying: rehash: Call objstorage.content_get() with a HashDict instead of single hash
Changes applied before test
commit 16cb9749f0015f49345ac9be59d0c68023aa941a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 14:09:46 2022 +0200
rehash: Call objstorage.content_get() with a HashDict instead of single hash
Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/452/ for more details.
Comment Actions
lgtm
Note: That's actually a tool (and not an indexer). It was used once some (long) time ago to add the blake
columns to the content model.
We never used it after that. I wonder whether we want to keep it or simply drop it to reduce
the maintenance volume to a minimum in that part of the code. And if we want to keep it, we might
want to move it somewhere else, make it a cli probably using the journal as well...
Comment Actions
Build is green
Patch application report for D8135 (id=30121)
Rebasing onto 85b675fd19...
Current branch diff-target is up to date.
Changes applied before test
commit 42cb37769714e245803023ccf02105006dd0e474
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 14:09:46 2022 +0200
rehash: Call objstorage.content_get() with a HashDict instead of single hash
Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/466/ for more details.