Differential D8102

Fix the load_and_check_config() function to support the "postgresql" cls value
ClosedPublic
Actions

Authored by douardda on Jul 8 2022, 2:09 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHd8474480aee9: Fix the load_and_check_config() function to support the "postgresql" cls value

Summary

and replace usage of the "local" scheduler cls with "postgresql" everywhere.

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 30328
Build 47414: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47413: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 8 2022, 2:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2022, 2:09 PM

reword the ci msg

douardda retitled this revision from Replace usage of the "local" scheduler cls with "postgresql" to Fix the load_and_check_config() function to support the "postgresql" cls value.Jul 8 2022, 2:11 PM

douardda edited the summary of this revision. (Show Details)

Build is green

Patch application report for D8102 (id=29241)

Rebasing onto 0496c3977a...

Current branch diff-target is up to date.

Changes applied before test

commit 89f924333846283483f5377930898522f117c869
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 14:00:33 2022 +0200

    Replace usage of the "local" scheduler cls with "postgresql"
    
    and fix the load_and_check_config() function to support the "postgresql"
    cls value.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/554/ for more details.

Harbormaster completed remote builds in B30327: Diff 29241.Jul 8 2022, 2:13 PM

Build is green

Patch application report for D8102 (id=29242)

Rebasing onto 0496c3977a...

Current branch diff-target is up to date.

Changes applied before test

commit 84f6854f3cdd541f3fd41097fa8b46e69e763bbe
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 14:00:33 2022 +0200

    Fix the load_and_check_config() function to support the "postgresql" cls value
    
    and replace usage of the "local" scheduler cls with "postgresql"
    everywhere.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/555/ for more details.

Harbormaster completed remote builds in B30328: Diff 29242.Jul 8 2022, 2:15 PM

douardda requested review of this revision.Jul 8 2022, 2:15 PM

ardumont added a subscriber: ardumont.Jul 8 2022, 2:34 PM

ardumont added inline comments.

swh/scheduler/celery_backend/pika_listener.py
108	wonder if that works (we moved away from the args parameter iirc.

lgtm

one comment inline

This revision is now accepted and ready to land.Jul 8 2022, 2:37 PM

douardda added inline comments.Jul 8 2022, 2:49 PM

swh/scheduler/celery_backend/pika_listener.py
108	ah yes you are ritght, but this main should better go away

minor fix (thx ardumont)

Build is green

Patch application report for D8102 (id=29250)

Rebasing onto 0496c3977a...

Current branch diff-target is up to date.

Changes applied before test

commit d8474480aee9a7ff873b8893ba6e558e4a2009fe
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 14:00:33 2022 +0200

    Fix the load_and_check_config() function to support the "postgresql" cls value
    
    and replace usage of the "local" scheduler cls with "postgresql"
    everywhere.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/556/ for more details.

Harbormaster completed remote builds in B30336: Diff 29250.Jul 8 2022, 2:56 PM

Closed by commit rDSCHd8474480aee9: Fix the load_and_check_config() function to support the "postgresql" cls value (authored by douardda). · Explain WhyJul 8 2022, 2:57 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSCHd8474480aee9: Fix the load_and_check_config() function to support the "postgresql" cls value.