Page MenuHomeSoftware Heritage

Fix the load_and_check_config() function to support the "postgresql" cls value
ClosedPublic

Authored by douardda on Jul 8 2022, 2:09 PM.

Details

Summary

and replace usage of the "local" scheduler cls with "postgresql" everywhere.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda retitled this revision from Replace usage of the "local" scheduler cls with "postgresql" to Fix the load_and_check_config() function to support the "postgresql" cls value.Jul 8 2022, 2:11 PM
douardda edited the summary of this revision. (Show Details)

Build is green

Patch application report for D8102 (id=29241)

Rebasing onto 0496c3977a...

Current branch diff-target is up to date.
Changes applied before test
commit 89f924333846283483f5377930898522f117c869
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 14:00:33 2022 +0200

    Replace usage of the "local" scheduler cls with "postgresql"
    
    and fix the load_and_check_config() function to support the "postgresql"
    cls value.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/554/ for more details.

Build is green

Patch application report for D8102 (id=29242)

Rebasing onto 0496c3977a...

Current branch diff-target is up to date.
Changes applied before test
commit 84f6854f3cdd541f3fd41097fa8b46e69e763bbe
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 14:00:33 2022 +0200

    Fix the load_and_check_config() function to support the "postgresql" cls value
    
    and replace usage of the "local" scheduler cls with "postgresql"
    everywhere.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/555/ for more details.

ardumont added inline comments.
swh/scheduler/celery_backend/pika_listener.py
107

wonder if that works (we moved away from the args parameter iirc.

lgtm

one comment inline

This revision is now accepted and ready to land.Jul 8 2022, 2:37 PM
swh/scheduler/celery_backend/pika_listener.py
107

ah yes you are ritght, but this main should better go away

douardda edited the summary of this revision. (Show Details)

minor fix (thx ardumont)

Build is green

Patch application report for D8102 (id=29250)

Rebasing onto 0496c3977a...

Current branch diff-target is up to date.
Changes applied before test
commit d8474480aee9a7ff873b8893ba6e558e4a2009fe
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 14:00:33 2022 +0200

    Fix the load_and_check_config() function to support the "postgresql" cls value
    
    and replace usage of the "local" scheduler cls with "postgresql"
    everywhere.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/556/ for more details.