Page MenuHomeSoftware Heritage
Differential D806

Small code cleanups
ClosedPublic
Actions

Authored by douardda on Dec 12 2018, 6:40 PM.

Details

Reviewers
ardumont
anlambert
Commits
rDLS5ff8093c5d5e: Simplify listers Model constructor
rDLS532fe90df506: Kill the XMLRPC transport
Summary
  • Kill the XMLRPC transport, it looks unused.
  • Simplify listers Model constructor
Test Plan

tox

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2990
Build 3818: tox-on-jenkinsJenkins
Build 3817: arc lint + arc unit

Event Timeline

douardda created this revision.Dec 12 2018, 6:40 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 12 2018, 6:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/18/ for more details.

Harbormaster completed remote builds in B2990: Diff 2565.Dec 12 2018, 6:42 PM
ardumont added a comment.Dec 12 2018, 6:44 PM

Kill the XMLRPC transport, it looks unused.

Yes, it's not.
That's an intermediary building step when finding the right way to discuss with the pypi api IIRC.
That never went away.

Thanks!

ardumont accepted this revision.Dec 12 2018, 6:58 PM

Cool!

Thanks for the cleanup!

This revision is now accepted and ready to land.Dec 12 2018, 6:58 PM
anlambert accepted this revision.Dec 14 2018, 10:51 AM

Nice code cleanup indeed!

Closed by commit rDLS532fe90df506: Kill the XMLRPC transport (authored by douardda). · Explain WhyDec 17 2018, 10:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
lister/
core/
57 lines
38 lines
github/
6 lines
gitlab/
11 lines

Diff 2565

View Options

swh/lister/core/lister_transports.py

Loading...
View Options

swh/lister/core/models.py

Loading...
View Options

swh/lister/github/models.py

Loading...
View Options

swh/lister/gitlab/models.py

Loading...
About · Developer information · Legal