Small code cleanups
ClosedPublic
Actions

Authored by douardda on Dec 12 2018, 6:40 PM.

Details

Reviewers

ardumont
anlambert

Commits

rDLS5ff8093c5d5e: Simplify listers Model constructor
rDLS532fe90df506: Kill the XMLRPC transport

Summary

Kill the XMLRPC transport, it looks unused.

Simplify listers Model constructor

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Dec 12 2018, 6:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/18/ for more details.

Harbormaster completed remote builds in B2990: Diff 2565.Dec 12 2018, 6:42 PM

Kill the XMLRPC transport, it looks unused.

Yes, it's not.
That's an intermediary building step when finding the right way to discuss with the pypi api IIRC.
That never went away.

Thanks!

Cool!

Thanks for the cleanup!

This revision is now accepted and ready to land.Dec 12 2018, 6:58 PM

Nice code cleanup indeed!

Closed by commit rDLS532fe90df506: Kill the XMLRPC transport (authored by douardda). · Explain WhyDec 17 2018, 10:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

core/

lister_transports.py

57 lines

Diff 2634

View Options

swh/lister/core/lister_transports.py

Small code cleanupsClosedPublicActions