Page MenuHomeSoftware Heritage

Small code cleanups
ClosedPublic

Authored by douardda on Dec 12 2018, 6:40 PM.

Details

Summary
  • Kill the XMLRPC transport, it looks unused.
  • Simplify listers Model constructor
Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Dec 12 2018, 6:40 PM

Kill the XMLRPC transport, it looks unused.

Yes, it's not.
That's an intermediary building step when finding the right way to discuss with the pypi api IIRC.
That never went away.

Thanks!

ardumont accepted this revision.Dec 12 2018, 6:58 PM

Cool!

Thanks for the cleanup!

This revision is now accepted and ready to land.Dec 12 2018, 6:58 PM
anlambert accepted this revision.Dec 14 2018, 10:51 AM

Nice code cleanup indeed!

This revision was automatically updated to reflect the committed changes.