Page MenuHomeSoftware Heritage

Drop the now unused add_stream and get_stream methods
ClosedPublic

Authored by olasd on Jun 21 2022, 5:52 PM.

Details

Summary

these methods were pretty much nullified by the use of RPC anyway

Test Plan

`grep -Er '(add|get)_stream' swh-environment/swh-*` only comes up with an unused method in the vault (dropped by D8012).

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29958
Build 46837: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 46836: arc lint + arc unit

Event Timeline

vlorentz accepted this revision.
This revision is now accepted and ready to land.Jun 21 2022, 5:53 PM

Build is green

Patch application report for D8013 (id=28871)

Rebasing onto 8394c6ad41...

Current branch diff-target is up to date.
Changes applied before test
commit 2c7e49136af690cfe5f41901ccbbdb381c30970a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 21 17:35:50 2022 +0200

    Drop the now unused add_stream and get_stream methods

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/152/ for more details.