Differential D8012

cache: Drop unused method get_stream
ClosedPublic
Actions

Authored by olasd on Jun 21 2022, 5:52 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDVAU6436f0bb3a62: cache: Drop unused method get_stream

Summary

This would be more usefully implemented by generating a (temporary) URL
for direct download of vault bundles from the azure bucket.

Test Plan

this method wasn't tested

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jun 21 2022, 5:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 21 2022, 5:52 PM

olasd mentioned this in D8013: Drop the now unused add_stream and get_stream methods.Jun 21 2022, 5:52 PM

vlorentz published this revision for review.Jun 21 2022, 5:52 PM

vlorentz accepted this revision.

This revision is now accepted and ready to land.Jun 21 2022, 5:52 PM

Build is green

Patch application report for D8012 (id=28870)

Rebasing onto da9203fcf2...

Current branch diff-target is up to date.

Changes applied before test

commit 6436f0bb3a62850fcfd7353c7d8e36767a84e265
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 21 17:51:03 2022 +0200

    cache: Drop unused method get_stream
    
    This would be more usefully implemented by generating a (temporary) URL
    for direct download of vault bundles from the azure bucket.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/237/ for more details.

Harbormaster completed remote builds in B29957: Diff 28870.Jun 21 2022, 5:54 PM

Closed by commit rDVAU6436f0bb3a62: cache: Drop unused method get_stream (authored by olasd). · Explain WhyJun 21 2022, 5:56 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDVAU6436f0bb3a62: cache: Drop unused method get_stream.