Page MenuHomeSoftware Heritage
Differential D8013

Drop the now unused add_stream and get_stream methods
ClosedPublic
Actions

Authored by olasd on Jun 21 2022, 5:52 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T4403: Update objstorage interface to return dicts of hashes instead of single sha1
Commits
rDOBJS2c7e49136af6: Drop the now unused add_stream and get_stream methods
Summary

these methods were pretty much nullified by the use of RPC anyway

Test Plan

`grep -Er '(add|get)_stream' swh-environment/swh-*` only comes up with an unused method in the vault (dropped by D8012).

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jun 21 2022, 5:52 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 21 2022, 5:52 PM
vlorentz published this revision for review.Jun 21 2022, 5:53 PM
vlorentz accepted this revision.
This revision is now accepted and ready to land.Jun 21 2022, 5:53 PM
swh-public-ci added a comment.Jun 21 2022, 5:55 PM

Build is green

Patch application report for D8013 (id=28871)

Rebasing onto 8394c6ad41...

Current branch diff-target is up to date.
Changes applied before test
commit 2c7e49136af690cfe5f41901ccbbdb381c30970a
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 21 17:35:50 2022 +0200

    Drop the now unused add_stream and get_stream methods

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/152/ for more details.

Harbormaster completed remote builds in B29958: Diff 28871.Jun 21 2022, 5:55 PM
Closed by commit rDOBJS2c7e49136af6: Drop the now unused add_stream and get_stream methods (authored by olasd). · Explain WhyJun 21 2022, 5:56 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDOBJS2c7e49136af6: Drop the now unused add_stream and get_stream methods.
vlorentz added a task: T4403: Update objstorage interface to return dicts of hashes instead of single sha1.Jul 19 2022, 3:19 PM

Revision Contents
Changeset List

PathSize
swh/
objstorage/
api/
15 lines
17 lines
backends/
9 lines
13 lines
43 lines
23 lines
9 lines
tests/
39 lines
7 lines

Diff 28873

View Options

swh/objstorage/api/client.py

Loading...
View Options

swh/objstorage/api/server.py

Loading...
View Options

swh/objstorage/backends/generator.py

Loading...
View Options

swh/objstorage/backends/in_memory.py

Loading...
View Options

swh/objstorage/backends/pathslicing.py

Loading...
View Options

swh/objstorage/interface.py

Loading...
View Options

swh/objstorage/objstorage.py

Loading...
View Options

swh/objstorage/tests/objstorage_testing.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_random_generator.py

Loading...
About · Developer information · Legal