In practice, it is not very useful to recompute it in the objstorage,
as callers already know it.
w/ @olasd
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T4403: Update objstorage interface to return dicts of hashes instead of single sha1
Diff Detail
Diff Detail
- Repository
- rDOBJS Object storage
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 29951 Build 46823: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 46822: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D8009 (id=28862)
Rebasing onto 8394c6ad41...
Current branch diff-target is up to date.
Changes applied before test
commit db7c8fe5d9d8e1c6568cb48d13cf172ec724efb3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jun 21 16:00:43 2022 +0200
Make obj_id argument of ObjStorage.add() required
In practice, it is not very useful to recompute it in the objstorage,
as callers already know it.Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/147/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/147/console
Comment Actions
Build has FAILED
Patch application report for D8009 (id=28864)
Rebasing onto 8394c6ad41...
Current branch diff-target is up to date.
Changes applied before test
commit 69f31ef58d7f8171709c4622fcd61502f82e6d9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jun 21 16:00:43 2022 +0200
Make obj_id argument of ObjStorage.add() required
In practice, it is not very useful to recompute it in the objstorage,
as callers already know it.Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/148/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/148/console
Comment Actions
Build is green
Patch application report for D8009 (id=28864)
Rebasing onto 8394c6ad41...
Current branch diff-target is up to date.
Changes applied before test
commit 69f31ef58d7f8171709c4622fcd61502f82e6d9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jun 21 16:00:43 2022 +0200
Make obj_id argument of ObjStorage.add() required
In practice, it is not very useful to recompute it in the objstorage,
as callers already know it.See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/150/ for more details.