Page MenuHomeSoftware Heritage

Make obj_id argument of ObjStorage.add() required
ClosedPublic

Authored by vlorentz on Tue, Jun 21, 4:01 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

In practice, it is not very useful to recompute it in the objstorage,
as callers already know it.

w/ @olasd

Diff Detail

Event Timeline

Build has FAILED

Patch application report for D8009 (id=28862)

Rebasing onto 8394c6ad41...

Current branch diff-target is up to date.
Changes applied before test
commit db7c8fe5d9d8e1c6568cb48d13cf172ec724efb3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:00:43 2022 +0200

    Make obj_id argument of ObjStorage.add() required
    
    In practice, it is not very useful to recompute it in the objstorage,
    as callers already know it.

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/147/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/147/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 21, 4:02 PM
Harbormaster failed remote builds in B29949: Diff 28862!

remove compute_hash from other backends

Build has FAILED

Patch application report for D8009 (id=28864)

Rebasing onto 8394c6ad41...

Current branch diff-target is up to date.
Changes applied before test
commit 69f31ef58d7f8171709c4622fcd61502f82e6d9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:00:43 2022 +0200

    Make obj_id argument of ObjStorage.add() required
    
    In practice, it is not very useful to recompute it in the objstorage,
    as callers already know it.

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/148/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/148/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 21, 4:15 PM
Harbormaster failed remote builds in B29951: Diff 28864!

Build is green

Patch application report for D8009 (id=28864)

Rebasing onto 8394c6ad41...

Current branch diff-target is up to date.
Changes applied before test
commit 69f31ef58d7f8171709c4622fcd61502f82e6d9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:00:43 2022 +0200

    Make obj_id argument of ObjStorage.add() required
    
    In practice, it is not very useful to recompute it in the objstorage,
    as callers already know it.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/150/ for more details.

This revision is now accepted and ready to land.Wed, Jun 22, 12:46 PM