Page MenuHomeSoftware Heritage

Make obj_id argument of ObjStorage.restore() required
ClosedPublic

Authored by vlorentz on Tue, Jun 21, 4:15 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

For consistency with ObjStorage.add() (D8009)

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29952
Build 46825: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 46824: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D8010 (id=28865)

Could not rebase; Attempt merge onto 8394c6ad41...

Updating 8394c6a..c0a9f1a
Fast-forward
 swh/objstorage/api/client.py                       |  2 +-
 swh/objstorage/backends/azure.py                   | 12 +-----
 swh/objstorage/backends/generator.py               |  2 +-
 swh/objstorage/backends/http.py                    |  4 +-
 swh/objstorage/backends/in_memory.py               |  5 +--
 swh/objstorage/backends/libcloud.py                |  8 +---
 swh/objstorage/backends/noop.py                    |  2 +-
 swh/objstorage/backends/pathslicing.py             |  5 +--
 swh/objstorage/backends/seaweedfs/objstorage.py    |  8 +---
 swh/objstorage/backends/winery/objstorage.py       | 20 +--------
 swh/objstorage/cli.py                              |  8 ++--
 swh/objstorage/interface.py                        |  8 ++--
 swh/objstorage/multiplexer/filter/filter.py        |  4 +-
 swh/objstorage/multiplexer/filter/id_filter.py     |  9 +---
 .../multiplexer/multiplexer_objstorage.py          |  4 +-
 swh/objstorage/objstorage.py                       | 10 ++---
 swh/objstorage/tests/objstorage_testing.py         |  6 ---
 swh/objstorage/tests/test_multiplexer_filter.py    | 48 +++++++++++-----------
 swh/objstorage/tests/test_objstorage_http.py       | 10 +++--
 .../tests/test_objstorage_multiplexer.py           |  4 +-
 swh/objstorage/tests/test_objstorage_striping.py   |  3 --
 swh/objstorage/tests/test_objstorage_winery.py     |  5 ++-
 22 files changed, 69 insertions(+), 118 deletions(-)
Changes applied before test
commit c0a9f1a41404ef20614f210f2c7c74f222e6727c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:05:45 2022 +0200

    Make obj_id argument of ObjStorage.restore() required
    
    For consistency with ObjStorage.add()

commit 69f31ef58d7f8171709c4622fcd61502f82e6d9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:00:43 2022 +0200

    Make obj_id argument of ObjStorage.add() required
    
    In practice, it is not very useful to recompute it in the objstorage,
    as callers already know it.

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/149/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/149/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 21, 4:16 PM
Harbormaster failed remote builds in B29952: Diff 28865!

Build is green

Patch application report for D8010 (id=28865)

Could not rebase; Attempt merge onto 8394c6ad41...

Updating 8394c6a..c0a9f1a
Fast-forward
 swh/objstorage/api/client.py                       |  2 +-
 swh/objstorage/backends/azure.py                   | 12 +-----
 swh/objstorage/backends/generator.py               |  2 +-
 swh/objstorage/backends/http.py                    |  4 +-
 swh/objstorage/backends/in_memory.py               |  5 +--
 swh/objstorage/backends/libcloud.py                |  8 +---
 swh/objstorage/backends/noop.py                    |  2 +-
 swh/objstorage/backends/pathslicing.py             |  5 +--
 swh/objstorage/backends/seaweedfs/objstorage.py    |  8 +---
 swh/objstorage/backends/winery/objstorage.py       | 20 +--------
 swh/objstorage/cli.py                              |  8 ++--
 swh/objstorage/interface.py                        |  8 ++--
 swh/objstorage/multiplexer/filter/filter.py        |  4 +-
 swh/objstorage/multiplexer/filter/id_filter.py     |  9 +---
 .../multiplexer/multiplexer_objstorage.py          |  4 +-
 swh/objstorage/objstorage.py                       | 10 ++---
 swh/objstorage/tests/objstorage_testing.py         |  6 ---
 swh/objstorage/tests/test_multiplexer_filter.py    | 48 +++++++++++-----------
 swh/objstorage/tests/test_objstorage_http.py       | 10 +++--
 .../tests/test_objstorage_multiplexer.py           |  4 +-
 swh/objstorage/tests/test_objstorage_striping.py   |  3 --
 swh/objstorage/tests/test_objstorage_winery.py     |  5 ++-
 22 files changed, 69 insertions(+), 118 deletions(-)
Changes applied before test
commit c0a9f1a41404ef20614f210f2c7c74f222e6727c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:05:45 2022 +0200

    Make obj_id argument of ObjStorage.restore() required
    
    For consistency with ObjStorage.add()

commit 69f31ef58d7f8171709c4622fcd61502f82e6d9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 21 16:00:43 2022 +0200

    Make obj_id argument of ObjStorage.add() required
    
    In practice, it is not very useful to recompute it in the objstorage,
    as callers already know it.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/151/ for more details.

This revision is now accepted and ready to land.Wed, Jun 22, 12:47 PM