Page MenuHomeSoftware Heritage

add_forge_now: Improve HTML and harmonize display style
ClosedPublic

Authored by anlambert on Tue, May 10, 12:14 PM.

Details

Summary

Slightly rework HTML code related to add forge now feature in
order to better integrate its UI into the webapp by:

  • using full width of bootstrap container for pages content
  • using bootstrap CSS classes when possible
  • removing useless DOM elements
  • wrapping long lines in HTML code

Before:


After:

Before:


After:

Before:


After:

Before:


After:

Before:


After:

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7797 (id=28167)

Rebasing onto 84fd757cf8...

Current branch diff-target is up to date.
Changes applied before test
commit 82637b0aa9558499619c87f1770a5c8c986f4f2b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 11:59:31 2022 +0200

    add_forge_now: Improve HTML and harmonize display style
    
    Slightly rework HTML code related to add forge now feature in
    order to better integrate its UI into the webapp by:
    
      - using full width of bootstrap container for pages content
    
      - using bootstrap CSS classes when possible
    
      - removing useless DOM elements
    
      - wrapping long lines in HTML code

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1813/ for more details.

vlorentz added a subscriber: vlorentz.

thanks, that's indeed better

This revision is now accepted and ready to land.Tue, May 10, 1:41 PM
This revision was landed with ongoing or failed builds.Tue, May 10, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7797 (id=28179)

Rebasing onto 9b80cf3706...

Current branch diff-target is up to date.
Changes applied before test
commit 83d38deb1648d17e41c62c8def99317ede9008a4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 11:59:31 2022 +0200

    add_forge_now: Improve HTML and harmonize display style
    
    Slightly rework HTML code related to add forge now feature in
    order to better integrate its UI into the webapp by:
    
      - using full width of bootstrap container for pages content
    
      - using bootstrap CSS classes when possible
    
      - removing useless DOM elements
    
      - wrapping long lines in HTML code

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1818/ for more details.