Differential D7797

add_forge_now: Improve HTML and harmonize display style
ClosedPublic
Actions

Authored by anlambert on May 10 2022, 12:14 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS83d38deb1648: add_forge_now: Improve HTML and harmonize display style

Summary

Slightly rework HTML code related to add forge now feature in
order to better integrate its UI into the webapp by:

using full width of bootstrap container for pages content
using bootstrap CSS classes when possible
removing useless DOM elements
wrapping long lines in HTML code

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Diff Detail

Repository

rDWAPPS Web applications

Branch

add-forge-now-improve-style-and-html

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29244
Build 45725: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45724: arc lint + arc unit

Event Timeline

anlambert created this revision.May 10 2022, 12:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 10 2022, 12:14 PM

Build is green

Patch application report for D7797 (id=28167)

Rebasing onto 84fd757cf8...

Current branch diff-target is up to date.

Changes applied before test

commit 82637b0aa9558499619c87f1770a5c8c986f4f2b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 11:59:31 2022 +0200

    add_forge_now: Improve HTML and harmonize display style
    
    Slightly rework HTML code related to add forge now feature in
    order to better integrate its UI into the webapp by:
    
      - using full width of bootstrap container for pages content
    
      - using bootstrap CSS classes when possible
    
      - removing useless DOM elements
    
      - wrapping long lines in HTML code

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1813/ for more details.

Harbormaster completed remote builds in B29233: Diff 28167.May 10 2022, 12:36 PM

anlambert requested review of this revision.May 10 2022, 12:36 PM

thanks, that's indeed better

This revision is now accepted and ready to land.May 10 2022, 1:41 PM

Rebase

This revision was landed with ongoing or failed builds.May 10 2022, 2:07 PM

Closed by commit rDWAPPS83d38deb1648: add_forge_now: Improve HTML and harmonize display style (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS83d38deb1648: add_forge_now: Improve HTML and harmonize display style.

Build is green

Patch application report for D7797 (id=28179)

Rebasing onto 9b80cf3706...

Current branch diff-target is up to date.

Changes applied before test

commit 83d38deb1648d17e41c62c8def99317ede9008a4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue May 10 11:59:31 2022 +0200

    add_forge_now: Improve HTML and harmonize display style
    
    Slightly rework HTML code related to add forge now feature in
    order to better integrate its UI into the webapp by:
    
      - using full width of bootstrap container for pages content
    
      - using bootstrap CSS classes when possible
    
      - removing useless DOM elements
    
      - wrapping long lines in HTML code

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1818/ for more details.

Harbormaster completed remote builds in B29244: Diff 28179.May 10 2022, 2:17 PM