svn: Fix subproject root directory when origin URL has a trailing slash
ClosedPublic
Actions

Authored by anlambert on May 5 2022, 2:00 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDSVNd84bdc1e2399: svn: Fix subproject root directory when origin URL has a trailing slash

Summary

The computed root directory name had a trailing slash which was making its
lookup in from_disk.Directory model fail and thus every archived revisions
were targetting the empty directory.

Issue spotted after a Save Code now request for http://svn.abisource.com/abiword/.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29086
Build 45468: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45467: arc lint + arc unit

Event Timeline

anlambert created this revision.May 5 2022, 2:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 5 2022, 2:00 PM

Build is green

Patch application report for D7744 (id=28007)

Rebasing onto 377aa32345...

Current branch diff-target is up to date.

Changes applied before test

commit d84bdc1e23994c88c72451694859f3019494127e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 5 13:55:31 2022 +0200

    svn: Fix subproject root directory when origin URL has a trailing slash
    
    The computed root directory name had a trailing slash which was making its
    lookup in from_disk.Directory model fail and thus every archived revisions
    were targetting the empty directory.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/328/ for more details.

Harbormaster completed remote builds in B29086: Diff 28007.May 5 2022, 2:03 PM

anlambert requested review of this revision.May 5 2022, 2:03 PM