Page MenuHomeSoftware Heritage

svn: Fix subproject root directory when origin URL has a trailing slash
ClosedPublic

Authored by anlambert on Thu, May 5, 2:00 PM.

Details

Summary

The computed root directory name had a trailing slash which was making its
lookup in from_disk.Directory model fail and thus every archived revisions
were targetting the empty directory.

Issue spotted after a Save Code now request for http://svn.abisource.com/abiword/.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7744 (id=28007)

Rebasing onto 377aa32345...

Current branch diff-target is up to date.
Changes applied before test
commit d84bdc1e23994c88c72451694859f3019494127e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 5 13:55:31 2022 +0200

    svn: Fix subproject root directory when origin URL has a trailing slash
    
    The computed root directory name had a trailing slash which was making its
    lookup in from_disk.Directory model fail and thus every archived revisions
    were targetting the empty directory.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/328/ for more details.

vlorentz added a subscriber: vlorentz.

another one!

This revision is now accepted and ready to land.Fri, May 6, 1:29 PM