Page MenuHomeSoftware Heritage

retry: re-raise original exception instead of a RetryError
ClosedPublic

Authored by olasd on Apr 13 2022, 3:39 PM.

Details

Summary

This will make the sentry reports more usable. If the exception changes
across calls, the earlier exceptions are still logged and available as
breadcrumbs.

Test Plan

new test added

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build was aborted

Patch application report for D7568 (id=27421)

Rebasing onto 75aa07325d...

Current branch diff-target is up to date.
Changes applied before test
commit bbb4fc1cb4721351753635a7fbe1004a231a5480
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Apr 13 15:37:57 2022 +0200

    retry: re-raise original exception instead of a RetryError
    
    This will make the sentry reports more usable. If the exception changes
    across calls, the earlier exceptions are still logged and available as
    breadcrumbs.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1596/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1596/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 13 2022, 3:55 PM
Harbormaster failed remote builds in B28435: Diff 27421!

Build is green

Patch application report for D7568 (id=27421)

Rebasing onto 75aa07325d...

Current branch diff-target is up to date.
Changes applied before test
commit bbb4fc1cb4721351753635a7fbe1004a231a5480
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Apr 13 15:37:57 2022 +0200

    retry: re-raise original exception instead of a RetryError
    
    This will make the sentry reports more usable. If the exception changes
    across calls, the earlier exceptions are still logged and available as
    breadcrumbs.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1597/ for more details.

olasd requested review of this revision.Apr 13 2022, 4:13 PM
This revision is now accepted and ready to land.Apr 13 2022, 4:23 PM