common/archive: Improve lookup_origin_visits performance
ClosedPublic
Actions

Authored by anlambert on Apr 12 2022, 4:32 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4090: Add method to efficiently retrieve latest statuses of origin visits

Commits

rDWAPPS731e01f396c4: common/archive: Improve lookup_origin_visits performance

Summary

Use new method origin_visit_get_with_statuses from storage interface
returning all visits and their statuses instead of querying latest
status for each visit.

Also bump the maximum number of visits per page from 50 to 1000.

Related to T4090

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 12 2022, 4:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 12 2022, 4:32 PM

Build is green

Patch application report for D7559 (id=27399)

Rebasing onto 96b38d9936...

Current branch diff-target is up to date.

Changes applied before test

commit 731e01f396c45e1455f66eb94022d0c1bad55d07
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 13:43:03 2022 +0200

    common/archive: Improve lookup_origin_visits performance
    
    Use new method origin_visit_get_with_statuses from storage interface
    returning all visits and their statuses instead of querying latest
    status for each visit.
    
    Also bump the maximum number of visits per page from 50 to 1000.
    
    Related to T4090

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1709/ for more details.

Harbormaster completed remote builds in B28410: Diff 27399.Apr 12 2022, 4:52 PM

anlambert requested review of this revision.Apr 12 2022, 4:52 PM

anlambert added a child revision: D7560: assets/origin/visits-histogram: Improve axis ticks rendering.Apr 12 2022, 5:16 PM

ardumont accepted this revision.Apr 12 2022, 5:37 PM

This revision is now accepted and ready to land.Apr 12 2022, 5:37 PM

Closed by commit rDWAPPS731e01f396c4: common/archive: Improve lookup_origin_visits performance (authored by anlambert). · Explain WhyApr 12 2022, 5:55 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS731e01f396c4: common/archive: Improve lookup_origin_visits performance.