Differential D7560

visits-histogram: Improve axis ticks rendering
ClosedPublic
Actions

Authored by anlambert on Apr 12 2022, 5:16 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS4e4939567e78: assets/origin/visits-histogram: Improve axis ticks rendering

Summary

Render at most 8 ticks for the vertical axis and compute step from
yMax instead of using a hardcoded value.

Filter out the 2014 label rendering on the horizontal axis.

Before:

After:

Depends on D7559

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 12 2022, 5:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 12 2022, 5:16 PM

Build is green

Patch application report for D7560 (id=27400)

Could not rebase; Attempt merge onto 96b38d9936...

Updating 96b38d99..4e493956
Fast-forward
 assets/src/bundles/origin/visits-histogram.js | 16 ++++++++++++----
 swh/web/common/archive.py                     | 15 +++++++--------
 2 files changed, 19 insertions(+), 12 deletions(-)

Changes applied before test

commit 4e4939567e780bc120def281c50c3214ce0873ed
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 17:13:05 2022 +0200

    assets/origin/visits-histogram: Improve axis ticks rendering
    
    Render at most 8 ticks for the vertical axis and compute step from
    yMax instead of using a hardcoded value.
    
    Filter out the 2014 label rendering on the horizontal axis.

commit 731e01f396c45e1455f66eb94022d0c1bad55d07
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 13:43:03 2022 +0200

    common/archive: Improve lookup_origin_visits performance
    
    Use new method origin_visit_get_with_statuses from storage interface
    returning all visits and their statuses instead of querying latest
    status for each visit.
    
    Also bump the maximum number of visits per page from 50 to 1000.
    
    Related to T4090

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1710/ for more details.

Harbormaster completed remote builds in B28411: Diff 27400.Apr 12 2022, 5:36 PM

anlambert requested review of this revision.Apr 12 2022, 5:36 PM

looks sensible enough ;)

ardumont accepted this revision.Apr 12 2022, 5:53 PM

This revision is now accepted and ready to land.Apr 12 2022, 5:53 PM

Closed by commit rDWAPPS4e4939567e78: assets/origin/visits-histogram: Improve axis ticks rendering (authored by anlambert). · Explain WhyApr 12 2022, 5:55 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4e4939567e78: assets/origin/visits-histogram: Improve axis ticks rendering.