Differential D7553

origin_get_with_statuses: Rename RPC endpoint path
ClosedPublic
Actions

Authored by anlambert on Apr 12 2022, 12:16 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO035d4c1dd19e: origin_get_with_statuses: Rename RPC endpoint path

Summary

Align RPC endpoint path with method name.

Depends on D7552

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 12 2022, 12:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 12 2022, 12:16 PM

Build is green

Patch application report for D7553 (id=27382)

Could not rebase; Attempt merge onto 7c9586a0bb...

Updating 7c9586a0..035d4c1d
Fast-forward
 swh/storage/cassandra/storage.py   | 51 +++++++++++++++++++-------------------
 swh/storage/interface.py           |  2 +-
 swh/storage/postgresql/storage.py  | 10 +++-----
 swh/storage/tests/storage_tests.py | 10 ++++++++
 4 files changed, 41 insertions(+), 32 deletions(-)

Changes applied before test

commit 035d4c1dd19e50b746be99e274d855c4a48efabe
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 12:15:41 2022 +0200

    origin_get_with_statuses: Rename RPC endpoint path
    
    Align RPC endpoint path with method name.

commit d255fb3c8a419cff80305990aae99d87e1d9b894
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 12:06:14 2022 +0200

    origin_get_with_statuses: Fix case when fetched visits list is empty
    
    Ensure to return an empty list of results when fetched visits list is
    empty, for instance when the provided page_token is greater or equal
    to latest origin visit.
    
    Related to T4090

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1591/ for more details.

Harbormaster completed remote builds in B28394: Diff 27382.Apr 12 2022, 12:27 PM

anlambert requested review of this revision.Apr 12 2022, 12:27 PM

ardumont accepted this revision.Apr 12 2022, 2:10 PM

This revision is now accepted and ready to land.Apr 12 2022, 2:10 PM

Closed by commit rDSTO035d4c1dd19e: origin_get_with_statuses: Rename RPC endpoint path (authored by anlambert). · Explain WhyApr 12 2022, 2:13 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTO035d4c1dd19e: origin_get_with_statuses: Rename RPC endpoint path.