This is more manageable than handling it manually with URL fragments
(which repeatedly breaks when adding new tabs).
This is just like D7428, except there is no redirect from the old URLs
(not needed, as this feature was not deployed yet)
Details
Details
- Reviewers
- None
- Group Reviewers
Reviewers - Commits
- rDWAPPSb0af8ee47d29: Add Forge Now: Use different views for each tab
This includes an ugly workaround in a test, because makes the tests run into an existing bug. D7440 will fix that bug
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1596/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1596/console
Comment Actions
Build has FAILED
Patch application report for D7439 (id=26940)
Could not rebase; Attempt merge onto 6b5aa57b3f...
Updating 6b5aa57b..fc7ee23e Fast-forward assets/src/bundles/add_forge/create-request.js | 29 +-- assets/src/bundles/save/index.js | 15 +- .../add-forge-now-request-create.spec.js | 21 ++- cypress/integration/origin-save.spec.js | 4 +- swh/web/add_forge_now/views.py | 26 ++- swh/web/misc/origin_save.py | 20 +- .../add_forge_now/create-request-create.html | 116 ++++++++++++ .../add_forge_now/create-request-help.html | 89 +++++++++ .../add_forge_now/create-request-list.html | 24 +++ .../templates/add_forge_now/create-request.html | 204 +-------------------- swh/web/templates/layout.html | 2 +- swh/web/templates/misc/origin-save-help.html | 54 ++++++ swh/web/templates/misc/origin-save-list.html | 27 +++ swh/web/templates/misc/origin-save.html | 67 +------ 14 files changed, 384 insertions(+), 314 deletions(-) create mode 100644 swh/web/templates/add_forge_now/create-request-create.html create mode 100644 swh/web/templates/add_forge_now/create-request-help.html create mode 100644 swh/web/templates/add_forge_now/create-request-list.html create mode 100644 swh/web/templates/misc/origin-save-help.html create mode 100644 swh/web/templates/misc/origin-save-list.html
Changes applied before test
commit fc7ee23e7639de0884c0307f588b2368e1581b55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 28 10:56:36 2022 +0200
Add Forge Now: Use different views for each tab
This is more manageable than handling it manually with URL fragments
(which repeatedly breaks when adding new tabs).
commit 84c22e278a3437beb06c8969d860c027cfd37f70
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Mar 25 10:46:29 2022 +0100
Save Code Now: Use different views for each tab
This is IMO more manageable than handling it manually with URL fragments
(which repeatedly breaks when adding new tabs).
A future commit will do this for Add Forge Now, too.Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1598/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1598/console
| swh/web/templates/add_forge_now/create-request-create.html | ||
|---|---|---|
| 1 | rename this one to create-request-form.html (or '-submit') to avoid the double 'create' in the name. | |
| swh/web/templates/add_forge_now/create-request-create.html | ||
|---|---|---|
| 1 | I'll do a round of renaming later, to fix all the inconsistencies | |
Comment Actions
This probably needs a rebase with anlambert's fix so the build has a chance to succeed.
Comment Actions
Build was aborted
Patch application report for D7439 (id=26962)
Could not rebase; Attempt merge onto 4bc8aaf1d9...
Updating 4bc8aaf1..b0af8ee4 Fast-forward assets/src/bundles/add_forge/create-request.js | 29 +-- assets/src/bundles/save/index.js | 15 +- .../add-forge-now-request-create.spec.js | 21 ++- cypress/integration/origin-save.spec.js | 4 +- swh/web/add_forge_now/views.py | 26 ++- swh/web/misc/origin_save.py | 20 +- .../add_forge_now/create-request-create.html | 116 ++++++++++++ .../add_forge_now/create-request-help.html | 89 +++++++++ .../add_forge_now/create-request-list.html | 24 +++ .../templates/add_forge_now/create-request.html | 204 +-------------------- swh/web/templates/layout.html | 2 +- swh/web/templates/misc/origin-save-help.html | 54 ++++++ swh/web/templates/misc/origin-save-list.html | 27 +++ swh/web/templates/misc/origin-save.html | 67 +------ 14 files changed, 384 insertions(+), 314 deletions(-) create mode 100644 swh/web/templates/add_forge_now/create-request-create.html create mode 100644 swh/web/templates/add_forge_now/create-request-help.html create mode 100644 swh/web/templates/add_forge_now/create-request-list.html create mode 100644 swh/web/templates/misc/origin-save-help.html create mode 100644 swh/web/templates/misc/origin-save-list.html
Changes applied before test
commit b0af8ee47d2926b542908539bf505f73f3b447a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 28 10:56:36 2022 +0200
Add Forge Now: Use different views for each tab
This is more manageable than handling it manually with URL fragments
(which repeatedly breaks when adding new tabs).
commit 72b5dd24dc3f783c702c47e36fd7a3ecd95b594c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Mar 25 10:46:29 2022 +0100
Save Code Now: Use different views for each tab
This is IMO more manageable than handling it manually with URL fragments
(which repeatedly breaks when adding new tabs).
A future commit will do this for Add Forge Now, too.Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1611/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1611/console