Differential D7422

test_client: Fix failing test since recent swh-model update
ClosedPublic
Actions

Authored by anlambert on Mar 24 2022, 2:34 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNL3771edbab33d: test_client: Fix failing test since recent swh-model update

Summary

swh.model.tests.swh_model_data.TEST_OBJECTS["revision"] now has
three sample revisions resulting in two revisions being processed
by kafka consumer in test_client_with_deserializer.

As there is no guarantee on the order messages are processed by
kafka consumer, we need to update test implementation to avoid
failures.

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27777
Build 43478: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43477: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	6,011 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.journal.tests.test_client::test_client_with_deserializer kafka_prefix = 'ijagrmzwck', kafka_consumer_group = 'test-consumer-ijagrmzwck' kafka_server = '127.0.0.1:59549'
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.journal.pytest_plugin::swh.journal.pytest_plugin.ensure_lists
	5,163 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.journal.tests.test_client::test_client
	5,662 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.journal.tests.test_client::test_client_batch_size[100]
	5,157 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.journal.tests.test_client::test_client_batch_size[1]
		View Full Test Results (1 Failed · 51 Passed)

Event Timeline

anlambert created this revision.Mar 24 2022, 2:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 24 2022, 2:34 PM

Build has FAILED

Patch application report for D7422 (id=26861)

Rebasing onto 33a8b959fe...

Current branch diff-target is up to date.

Changes applied before test

commit 4e64c9266870a3cd9ac44b072cc24d500f422974
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Mar 24 14:30:40 2022 +0100

    test_client: Fix failing test since recent swh-model update
    
    swh.model.tests.swh_model_data.TEST_OBJECTS["revision"] now has
    three sample revisions resulting in two revisions being processed
    by kafka consumer in test_client_with_deserializer.
    
    As there is no guarantee on the order messages are processed by
    kafka consumer, we need to update test implementation to avoid
    failures.

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/196/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/196/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 24 2022, 2:38 PM

Harbormaster failed remote builds in B27777: Diff 26861!

Python 3.7 fix

Build is green

Patch application report for D7422 (id=26862)

Rebasing onto 33a8b959fe...

Current branch diff-target is up to date.

Changes applied before test

commit 3771edbab33dd220c6ec9bf32dee9b10947f55ef
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Mar 24 14:30:40 2022 +0100

    test_client: Fix failing test since recent swh-model update
    
    swh.model.tests.swh_model_data.TEST_OBJECTS["revision"] now has
    three sample revisions resulting in two revisions being processed
    by kafka consumer in test_client_with_deserializer.
    
    As there is no guarantee on the order messages are processed by
    kafka consumer, we need to update test implementation to avoid
    failures.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/197/ for more details.

Harbormaster completed remote builds in B27778: Diff 26862.Mar 24 2022, 2:49 PM

anlambert requested review of this revision.Mar 24 2022, 2:49 PM

ardumont accepted this revision.Mar 24 2022, 3:13 PM

This revision is now accepted and ready to land.Mar 24 2022, 3:13 PM

Closed by commit rDJNL3771edbab33d: test_client: Fix failing test since recent swh-model update (authored by anlambert). · Explain WhyMar 24 2022, 3:36 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDJNL3771edbab33d: test_client: Fix failing test since recent swh-model update.

vlorentz added a subscriber: vlorentz.Mar 24 2022, 3:41 PM

vlorentz added inline comments.