Page MenuHomeSoftware Heritage

Remove method add_stream from the RPC API.
ClosedPublic

Authored by vlorentz on Mar 1 2022, 3:10 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rDOBJSb159f04b8d59: Remove method add_stream from the RPC API.
Summary

Rationale:

  1. Only the pathslicing backend implements it
  2. No other package uses it (besides a dead code path in the vault)
  3. A future commit will rewrite the RPC server to use Flask instead of aiohttp, and rewriting this view correctly is going to be hard (though possible)

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27199
Build 42545: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42544: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7267 (id=26326)

Rebasing onto 76a5f36b41...

Current branch diff-target is up to date.
Changes applied before test
commit b159f04b8d591947003cf3a4cd15fbcf0f3cb31e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 1 13:36:02 2022 +0100

    Remove method add_stream from the RPC API.
    
    Rationale:
    
    1. Only the pathslicing backend implements it
    2. No other package uses it (besides a dead code path in the vault)
    3. A future commit will rewrite the RPC server to use Flask instead of
       aiohttp, and rewriting this view correctly is going to be hard
       (though possible)

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/119/ for more details.

olasd added a subscriber: olasd.

Cool, thanks

This revision is now accepted and ready to land.Mar 1 2022, 4:36 PM
vlorentz added a task: Restricted Maniphest Task.Mar 1 2022, 5:26 PM