Differential D7267

Remove method add_stream from the RPC API.
ClosedPublic
Actions

Authored by vlorentz on Mar 1 2022, 3:10 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDOBJSb159f04b8d59: Remove method add_stream from the RPC API.

Summary

Rationale:

Only the pathslicing backend implements it
No other package uses it (besides a dead code path in the vault)
A future commit will rewrite the RPC server to use Flask instead of aiohttp, and rewriting this view correctly is going to be hard (though possible)

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 1 2022, 3:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 1 2022, 3:10 PM

Build is green

Patch application report for D7267 (id=26326)

Rebasing onto 76a5f36b41...

Current branch diff-target is up to date.

Changes applied before test

commit b159f04b8d591947003cf3a4cd15fbcf0f3cb31e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 1 13:36:02 2022 +0100

    Remove method add_stream from the RPC API.
    
    Rationale:
    
    1. Only the pathslicing backend implements it
    2. No other package uses it (besides a dead code path in the vault)
    3. A future commit will rewrite the RPC server to use Flask instead of
       aiohttp, and rewriting this view correctly is going to be hard
       (though possible)

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/119/ for more details.

Harbormaster completed remote builds in B27199: Diff 26326.Mar 1 2022, 3:12 PM

vlorentz requested review of this revision.Mar 1 2022, 3:12 PM

vlorentz added a child revision: D7272: Use flask instead of aiohttp as RPC server..Mar 1 2022, 4:32 PM