Ensure metadata provenance url matches provider url when provided
ClosedPublic
Actions

Authored by ardumont on Feb 24 2022, 11:25 AM.

Details

Reviewers

vlorentz
moranegg

Group Reviewers

Reviewers

Maniphest Tasks

T3677: Separate origin-source-code and provenance-metadata in the deposit

Commits

rDDEPccff46762b0e: Ensure metadata provenance url matches provider url when provided

Summary

This will refuse the metadata-only deposit if the metadata provenance does not match.
This is doing a similar check already done when doing deposit with origin url
mismatching that same (client) provider url.

Related to T3677

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27113
Build 42403: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42402: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 24 2022, 11:25 AM

ardumont mentioned this in D7227: cli: Warn when metadata-only deposit without metadata provenance.Feb 24 2022, 11:26 AM

vlorentz published this revision for review.Feb 24 2022, 11:31 AM

vlorentz accepted this revision.

This revision is now accepted and ready to land.Feb 24 2022, 11:32 AM

Build is green

Patch application report for D7238 (id=26241)

Rebasing onto 136cbaba04...

Current branch diff-target is up to date.

Changes applied before test

commit de6ea71109ace952c86aa04d2f84c0739853722b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 24 11:07:06 2022 +0100

    Ensure metadata provenance url matches provider url when provided
    
    This will refuse the metadata-only deposit if the metadata provenance does not match.
    This is doing a similar check already done when doing deposit with origin url
    mismatching that same (client) provider url.
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/755/ for more details.

Harbormaster completed remote builds in B27113: Diff 26241.Feb 24 2022, 11:33 AM

Rework test to actually have check that goes through with some valid provenance meta url
(and deal with impacts with existing tests).

Build is green

Patch application report for D7238 (id=26247)

Rebasing onto f520d976f4...

Current branch diff-target is up to date.

Changes applied before test

commit ccff46762b0ef9b5b7b00580a89dc8318fd8ff5c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 24 11:07:06 2022 +0100

    Ensure metadata provenance url matches provider url when provided
    
    This will refuse the metadata-only deposit if the metadata provenance does not match.
    This is doing a similar check already done when doing deposit with origin url
    mismatching that same (client) provider url.
    
    Related to T3677

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/757/ for more details.

Harbormaster completed remote builds in B27119: Diff 26247.Feb 24 2022, 11:59 AM

Closed by commit rDDEPccff46762b0e: Ensure metadata provenance url matches provider url when provided (authored by ardumont). · Explain WhyFeb 24 2022, 12:00 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEPccff46762b0e: Ensure metadata provenance url matches provider url when provided.