Page MenuHomeSoftware Heritage

Adapt indexer to swh.core 2.0.0
ClosedPublic

Authored by douardda on Feb 11 2022, 5:08 PM.

Details

Summary
  • add the get_datastore function in swh.indexer
  • add the get_current_version method in IndexerBackend,
  • remove dbversion management from sql init script
  • update tests accordingly

Depends on D7155
Related to T3894

Diff Detail

Event Timeline

Build has FAILED

Patch application report for D7164 (id=25966)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.
Changes applied before test
commit c2758e6547ede817b1d7cf2bd05c3aa6798b56b5
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/189/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/189/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2022, 5:09 PM
Harbormaster failed remote builds in B26842: Diff 25966!
douardda retitled this revision from Adapt to swh.core 2.0.0 to Adapt indexer to swh.core 2.0.0.Feb 11 2022, 5:13 PM

Build has FAILED

Patch application report for D7164 (id=25966)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.
Changes applied before test
commit c2758e6547ede817b1d7cf2bd05c3aa6798b56b5
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/190/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/190/console

small flake8 and mypy fixes

Build has FAILED

Patch application report for D7164 (id=26205)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.
Changes applied before test
commit d400d5161b2c447636b6485d86f2e4d1ff5b1af0
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/191/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/191/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2022, 2:36 PM
Harbormaster failed remote builds in B27078: Diff 26205!

forgot to commit requirements file

Build has FAILED

Patch application report for D7164 (id=26207)

Rebasing onto 38bae9837b...

Current branch diff-target is up to date.
Changes applied before test
commit 8cb650cab81c4067be24fcaeb41150ff81558fe7
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/192/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/192/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2022, 2:56 PM
Harbormaster failed remote builds in B27080: Diff 26207!

Build is green

Patch application report for D7164 (id=26236)

Rebasing onto 12c3f4cf87...

Current branch diff-target is up to date.
Changes applied before test
commit 9fb219a65d01b32c421808d9904373f5d07ba7db
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/195/ for more details.

vlorentz added inline comments.
requirements-test.txt
10 ↗(On Diff #26236)

why?

This revision is now accepted and ready to land.Feb 24 2022, 12:04 PM
requirements-test.txt
10 ↗(On Diff #26236)

why?

because mypy told me so (did not dig further, just did what I was told)

remove the dep on types-toml

seems not needed after all.

Build is green

Patch application report for D7164 (id=26285)

Rebasing onto 12c3f4cf87...

Current branch diff-target is up to date.
Changes applied before test
commit 9e89b83be45582d7b709f192a83d14c7433641f2
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:57:30 2022 +0100

    Adapt to swh.core  2.0.0
    
    - add the `get_datastore` function in `swh.indexer`
    - add the `get_current_version` method in `IndexerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/196/ for more details.

This revision was automatically updated to reflect the committed changes.