Instead of a generic 500.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS0bcfbb21c419: mailmaps: Return a proper error in case of duplicate from_email
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7096 (id=25748)
Could not rebase; Attempt merge onto d4ca7bede2...
Updating d4ca7bed..ca4020e9 Fast-forward swh/web/auth/mailmap.py | 16 +++++++++++++++- swh/web/tests/auth/test_mailmap.py | 36 +++++++++++++++++++++++++++++++++++- 2 files changed, 50 insertions(+), 2 deletions(-)
Changes applied before test
commit ca4020e97dcf6ee4fc987400646fad6ccce87824
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Feb 7 14:50:58 2022 +0100
mailmaps: Return a proper error in case of duplicate from_email
Instead of a generic 500.
commit 98bdf12aea75bdcc2e3e96b49515112987daa164
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Feb 7 14:49:54 2022 +0100
mailmaps: Add an endpoint to fetch the list
This will be useful for debugging and checking records are indeed
configured.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1343/ for more details.
| swh/web/auth/mailmap.py | ||
|---|---|---|
| 45 | You should check if from_email is contained in the error message. I did that originally but I encountered other IntegrityError with malformed data | |
| swh/web/auth/mailmap.py | ||
|---|---|---|
| 45 | ah no it's not. I'll send a new diff. | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1354/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1354/console