Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3848: Activate saved origin browse link only when loading data are available in database
- Commits
- rDWAPPSd91cacc70124: assets/save: Add origin browse link only for valid visit statuses
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7044 (id=25535)
Could not rebase; Attempt merge onto 0733a8de5b...
Updating 0733a8de..d91cacc7 Fast-forward assets/src/bundles/save/index.js | 13 +- assets/src/bundles/vault/vault-create-tasks.js | 27 ++- assets/src/bundles/webapp/webapp-utils.js | 12 +- cypress/fixtures/origin-save.json | 183 ++++++++++++--------- cypress/integration/origin-save.spec.js | 27 +++ cypress/integration/vault.spec.js | 7 +- swh/web/templates/includes/vault-create-tasks.html | 4 +- 7 files changed, 173 insertions(+), 100 deletions(-)
Changes applied before test
commit d91cacc70124212c9bc16507b023273c34724309
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Wed Jan 26 16:29:43 2022 +0100
assets/save: Add origin browse link only for valid visit statuses
In the Save Code Now Web UI, add the link to browse a saved origin
only if the visit status is valid.
This prevents to browse the saved origin when loading data are not
yet available in storage database (replication lag for instance).
Related to T3848
commit 07a63d61920e5c00d0c349cd1fcdcef319f29f6d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Wed Jan 26 15:06:21 2022 +0100
assets/vault: Trigger task creation when hitting enter key on modals
Simulate HTML form behavior by adding a keyup event listener on the
vault modals dedicated to tasks creation.
Related to T3845See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1308/ for more details.