Differential D7040

assets/vault: Trigger task creation when hitting enter key on modals
ClosedPublic
Actions

Authored by anlambert on Jan 26 2022, 3:09 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3845: Requesting cooking with email address + "Enter " key returns an error

Commits

rDWAPPS07a63d61920e: assets/vault: Trigger task creation when hitting enter key on modals

Summary

Simulate HTML form behavior by adding a keyup event listener on the
vault modals dedicated to tasks creation.

Related to T3845

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 26 2022, 3:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 26 2022, 3:09 PM

vlorentz added a subscriber: vlorentz.Jan 26 2022, 3:12 PM

vlorentz added inline comments.

cypress/integration/vault.spec.js
326–328	shouldn't cypress test both?

Build is green

Patch application report for D7040 (id=25528)

Rebasing onto 0733a8de5b...

Current branch diff-target is up to date.

Changes applied before test

commit 07a63d61920e5c00d0c349cd1fcdcef319f29f6d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jan 26 15:06:21 2022 +0100

    assets/vault: Trigger task creation when hitting enter key on modals
    
    Simulate HTML form behavior by adding a keyup event listener on the
    vault modals dedicated to tasks creation.
    
    Related to T3845

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1307/ for more details.

Harbormaster completed remote builds in B26360: Diff 25528.Jan 26 2022, 3:28 PM

anlambert requested review of this revision.Jan 26 2022, 3:28 PM

anlambert added a child revision: D7044: assets/save: Add origin browse link only for valid visit statuses.Jan 26 2022, 4:34 PM

anlambert added inline comments.Jan 27 2022, 11:15 AM

cypress/integration/vault.spec.js
326–328	The click behavior is already tested in the previous test and hitting enter simply trigger a click event on the Ok button, so no need to complicate the test here.