Also fix the 'committer_date' on the PG Storage's revision_add,
that slipped through D676.
Details
Details
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/114/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/115/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/116/ for more details.
| swh/storage/in_memory.py | ||
|---|---|---|
| 386–401 | More than the type described here, svn, hg, etc... **type** (str): revision type (e.g git, tar, svn, hg, etc...) | |
Comment Actions
I'm ok with this Diff, but I'd appreciate a bit more details for this type argument.
| swh/storage/in_memory.py | ||
|---|---|---|
| 386–401 | Ideally we'd like to have a simple way of knowing which values are possible for a given instance of the platform. Or at least add a few words telling where these accepted values come from (here, the list of supported loader, or more precisely the possible values of the 'type' key in the origin member of loader instances, which is a bit painful to explain is a docstring...) Not sure what's the best link to put here to reference the origin "schema", but i would be nice to have such a link. Also applies to the same hunk on storage.py. | |
| swh/storage/in_memory.py | ||
|---|---|---|
| 386–401 | The only reference I know of is this one: https://forge.softwareheritage.org/source/swh-storage/browse/master/swh/storage/sql/20-swh-enums.sql$8 :/ | |
| swh/storage/in_memory.py | ||
|---|---|---|
| 386–401 | Yes, i do not see a better link than this one right now. | |