This simply take the origin provided by the journal listener and
forwards it to the topic of reified objects.
Depends on D693
Details
Details
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Branch
- process-origins
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2608 Build 3240: tox-on-jenkins Jenkins Build 3239: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/14/ for more details.
Comment Actions
Same as D692; LGTM but I really don't *see* what this diff is actually *doing*. Just reading this, seems like a convoluted way of testing the equality of a dict with itself, but I guess I miss some bigger picture...
Comment Actions
but I really don't *see* what this diff is actually *doing*. Just reading this, seems like a convoluted way of testing the equality of a dict with itself, but I guess I miss some bigger picture...
More details on answer [1]
Comment Actions
convoluted way of testing the equality of a dict with itself,
Since i did not have time to unstuck me on running a real kafka instance in test context (out of scope for this week ;)
I still needed to check that the data is indeed flowing through ;)
The publisher's process_objects method is the one running at the core of the publisher.
Independently of the topic subscription/publishing step (which is stuck in tests for now).
So yeah, in the end, that not much. That's better than nothing though.
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/15/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/15/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/16/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/16/console