Page MenuHomeSoftware Heritage

Increase retries for random walks from 5 to 10
ClosedPublic

Authored by seirl on Fri, Jan 7, 4:26 PM.

Details

Summary

Decreases probability of test failure from 3.12% to 0.097%.

Fix T3831

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6893 (id=25003)

Could not rebase; Attempt merge onto 4d36535f9e...

Updating 4d36535..6ecd6b8
Fast-forward
 .../java/org/softwareheritage/graph/Entry.java     | 24 +++++++++++-----------
 swh/graph/backend.py                               |  4 ++--
 swh/graph/server/app.py                            | 17 +++++++++++++--
 3 files changed, 29 insertions(+), 16 deletions(-)
Changes applied before test
commit 6ecd6b87d049fbf795e1f211d72f77beb837d93b
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Jan 7 16:25:21 2022 +0100

    Increase retries for random walks from 5 to 10
    
    Decreases probability of test failure from 3.12% to 0.097%.
    
    Fix T3831

commit 3b16d990923fcf1a82e28bac0c6bc3e06754af91
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Jan 7 15:58:59 2022 +0100

    Add max_edges argument to all the endpoints

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/147/ for more details.

seirl requested review of this revision.Fri, Jan 7, 4:28 PM

Decreases probability of test failure from 3.12% to 0.097%.

lol :D

where do you compute that from?

>>> 1/(2**10)
0.0009765625
>>> 1/(2**5)
0.03125

The probably is still too high IMO. You could make tests temporarily increase this value

Make random_walk tests deterministic

Here, I changed it so that all the paths go to the correct node.

Build is green

Patch application report for D6893 (id=25142)

Rebasing onto 1a1bb59c1b...

Current branch diff-target is up to date.
Changes applied before test
commit 64f35108dddd4120f6365b7aacc4b043136c45f3
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Thu Jan 13 15:51:29 2022 +0100

    Make random_walk tests deterministic

commit c2074adc3d2c885cb1c725d12d993debea4fbfab
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Jan 7 16:25:21 2022 +0100

    Increase retries for random walks from 5 to 10
    
    Decreases probability of test failure from 3.12% to 0.097%.
    
    Fix T3831

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/151/ for more details.

anlambert added a subscriber: anlambert.

Great, thanks !

This revision is now accepted and ready to land.Thu, Jan 13, 4:06 PM