Differential D6879

loader: Fix parsing of last dumped revision
ClosedPublic
Actions

Authored by anlambert on Jan 5 2022, 1:12 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN1b13c5c19ef3: loader: Fix parsing of last dumped revision

Summary

svnrdump can output multiple error messages so we need to iterate
in reverse order on stderr output until finding a line that starts
with "* Dumped revision".

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 5 2022, 1:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 5 2022, 1:12 PM

Build is green

Patch application report for D6879 (id=24943)

Rebasing onto 196c9d596b...

Current branch diff-target is up to date.

Changes applied before test

commit 886e2683bb2c68af6b956fc30cb869c4c860ae6f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 4 17:48:28 2022 +0100

    loader: Fix parsing of last dumped revision
    
    svnrdump can output multiple error messages so we need to iterate
    in reverse order on stderr output until finding a line that starts
    with "* Dumped revision".

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/217/ for more details.

Harbormaster completed remote builds in B25814: Diff 24943.Jan 5 2022, 1:13 PM

anlambert requested review of this revision.Jan 5 2022, 1:13 PM

ardumont accepted this revision.Jan 5 2022, 3:18 PM

This revision is now accepted and ready to land.Jan 5 2022, 3:18 PM

rebase

Build is green

Patch application report for D6879 (id=24953)

Rebasing onto 27df073594...

Current branch diff-target is up to date.

Changes applied before test

commit 1b13c5c19ef36528a9a005cbadc427cde3a10add
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 4 17:48:28 2022 +0100

    loader: Fix parsing of last dumped revision
    
    svnrdump can output multiple error messages so we need to iterate
    in reverse order on stderr output until finding a line that starts
    with "* Dumped revision".

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/221/ for more details.

Harbormaster completed remote builds in B25824: Diff 24953.Jan 5 2022, 4:17 PM

Closed by commit rDLDSVN1b13c5c19ef3: loader: Fix parsing of last dumped revision (authored by anlambert). · Explain WhyJan 5 2022, 4:18 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN1b13c5c19ef3: loader: Fix parsing of last dumped revision.